-
Notifications
You must be signed in to change notification settings - Fork 13
machine_configuration: Update readme #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
see my comments above. |
machine_configuration/README.md
Outdated
``` | ||
Ensure that ast driver is not loaded. | ||
Ensure that i915 and intel_vsec driver is not loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the in-tree i915 and intel_vsec driver is not loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it
machine_configuration/README.md
Outdated
``` | ||
$ oc apply -f https://raw.githubusercontent.com/intel/intel-technology-enabling-for-openshift/main/machine_configuration/100-intel-dgpu-machine-config-disable-ast.yaml | ||
$ oc apply -f https://raw.githubusercontent.com/intel/intel-technology-enabling-for-openshift/main/machine_configuration/100-intel-dgpu-machine-config-disable-i915.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the configuration file name to
100-intel-dgpu-machine-config-disable-intree-i915-vsec
Could you submit a PR to change the file name? And resubmit this PR after that. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change commit log
machine_configuration: Update readme
disable the in-tree i915 and intel_vsec configuration so KMM can insmod the
OOT drivers.
It is the short-term solution. In the long-run the drivers rmmod should be handled in KMM operator
Signed-off-by: Hersh Pathak hersh.pathak@intel.com
Disable the in-tree i915 and intel_vsec configuration so KMM can modprobe the OOT drivers. This is the short-term solution. In the long-run, the in-tree drivers unload should be handled by KMM operator. Signed-off-by: Hersh Pathak hersh.pathak@intel.com
37672b0
to
4552fe4
Compare
Updated PR, thanks for the feedback @uMartinXu! |
LGTM |
Disable the in-tree i915 and intel_vsec configuration so KMM can modprobe the
OOT drivers.
This is the short-term solution. In the long-run, the in-tree drivers unload should be handled by KMM operator.
Signed-off-by: Hersh Pathak hersh.pathak@intel.com