Skip to content

machine_configuration: Update readme #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

hershpa
Copy link
Contributor

@hershpa hershpa commented Dec 8, 2023

Disable the in-tree i915 and intel_vsec configuration so KMM can modprobe the
OOT drivers.
This is the short-term solution. In the long-run, the in-tree drivers unload should be handled by KMM operator.

Signed-off-by: Hersh Pathak hersh.pathak@intel.com

@hershpa hershpa added documentation Improvements or additions to documentation machine_config Machine Configuration labels Dec 8, 2023
@hershpa hershpa added this to the v1.1.0 milestone Dec 8, 2023
@hershpa hershpa requested a review from uMartinXu December 8, 2023 01:16
@hershpa hershpa self-assigned this Dec 8, 2023
@uMartinXu
Copy link
Contributor

see my comments above.

```
Ensure that ast driver is not loaded.
Ensure that i915 and intel_vsec driver is not loaded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the in-tree i915 and intel_vsec driver is not loaded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

```
$ oc apply -f https://raw.githubusercontent.com/intel/intel-technology-enabling-for-openshift/main/machine_configuration/100-intel-dgpu-machine-config-disable-ast.yaml
$ oc apply -f https://raw.githubusercontent.com/intel/intel-technology-enabling-for-openshift/main/machine_configuration/100-intel-dgpu-machine-config-disable-i915.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change the configuration file name to
100-intel-dgpu-machine-config-disable-intree-i915-vsec
Could you submit a PR to change the file name? And resubmit this PR after that. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change commit log
machine_configuration: Update readme

disable the in-tree i915 and intel_vsec configuration so KMM can insmod the
OOT drivers.
It is the short-term solution. In the long-run the drivers rmmod should be handled in KMM operator

Signed-off-by: Hersh Pathak hersh.pathak@intel.com

Disable the in-tree i915 and intel_vsec configuration so KMM can modprobe the
OOT drivers.
This is the short-term solution. In the long-run, the in-tree drivers unload should be handled by KMM operator.

Signed-off-by: Hersh Pathak hersh.pathak@intel.com
@hershpa
Copy link
Contributor Author

hershpa commented Dec 8, 2023

Updated PR, thanks for the feedback @uMartinXu!

@hershpa hershpa changed the title machine_configuration: Update readme to apply the disable in-tree i915 and intel_vsec configuration machine_configuration: Update readme Dec 8, 2023
@uMartinXu
Copy link
Contributor

LGTM

@uMartinXu uMartinXu merged commit e9eeeca into intel:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation machine_config Machine Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants