media: ov2740: Fix "clk already disabled" / "already unprepared" oops / backtraces #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrdegoede
changed the title
jwrdegoede
force-pushed
the
ov2740-clk-WARN-fix
branch
from
b7d2fb0 to
f75ad74
Compare
…traces On probe() the ov2740 code was manually setting the reset GPIO instead of using the power_on() helper function. This path however left out enabling the clk, which power_on() does do, so when power_off() runs after the probe() is done (on runtime suspend) then there are 2 ugly backtraces triggered by WARN()s in the clk-core. One for "clk already disabled" followed by one for "clk already unprepared". Fix this by using the power_on() helper in probe(). Signed-off-by: Hans de Goede <hdegoede@redhat.com>
jwrdegoede
force-pushed
the
ov2740-clk-WARN-fix
branch
from
f75ad74 to
f042dae
Compare
|
New push:
|
|
Thank you @jwrdegoede . I also changed this part recently to prepare sending changes together with upstreamed IPU6 driver. The settings for CJFLE23 is actually 180MHz link frequency and seems Thinkpad X1 can't run the 360MHz setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On probe() the ov2740 code was manually setting the reset GPIO instead of using the power_on() helper function.
This path however left out enabling the clk, which power_on() does do, so when power_off() runs after the probe() is done (on runtime suspend) then there are 2 ugly backtraces triggered by WARN()s in the clk-core. One for "clk already disabled" followed by one for "clk already unprepared".
Fix this by using the power_on() helper in probe().