Skip to content

Commit

Permalink
Fix abi and disable tests in L0
Browse files Browse the repository at this point in the history
  • Loading branch information
fabiomestre committed Jan 14, 2025
1 parent 9acfb29 commit 075eb00
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 6 deletions.
2 changes: 1 addition & 1 deletion sycl/include/sycl/ext/oneapi/experimental/graph.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ class __SYCL_EXPORT dynamic_parameter_base {

void updateAccessor(const sycl::detail::AccessorBaseHost *Acc);

sycl::detail::LocalAccessorImplPtr getLocalAccessor(handler *Handler);
sycl::detail::LocalAccessorImplPtr getLocalAccessor(handler *Handler) const;

void
registerLocalAccessor(sycl::detail::LocalAccessorBaseHost *LocalAccBaseHost,
Expand Down
2 changes: 1 addition & 1 deletion sycl/source/detail/graph_impl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1492,7 +1492,7 @@ class dynamic_parameter_impl {
/// @return returns the impl object for the local accessor that is associated
/// with this handler. Or nullptr if no local accessor has been registered
/// for this handler.
sycl::detail::LocalAccessorImplPtr getLocalAccessor(handler *Handler);
sycl::detail::LocalAccessorImplPtr getLocalAccessor(handler *Handler) const;

/// Associates a local accessor with this dynamic local accessor for a
/// specific handler.
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Update/dyn_cgf_dyn_local_accessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// XFAIL: level_zero
// XFAIL-TRACKER: OFNAAO-422

// Tests using dynamic command-group objects with dynamic local accessors.

#include "../graph_common.hpp"
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Update/update_dynamic_local_accessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// XFAIL: level_zero
// XFAIL-TRACKER: OFNAAO-422

// Tests updating local accessor parameters.
#include "../graph_common.hpp"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// XFAIL: level_zero
// XFAIL-TRACKER: OFNAAO-422

// Tests updating local accessor parameters using multiple dynamic local
// accessors in the graph node.
#include "../graph_common.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// XFAIL: level_zero
// XFAIL-TRACKER: OFNAAO-422

// Tests updating local 2D local accessor parameters in multiple graph nodes
// simultaneously. Also tests using dynamic local accessors with
// non-zero indices.
Expand Down
10 changes: 6 additions & 4 deletions sycl/test/abi/sycl_symbols_linux.dump
Original file line number Diff line number Diff line change
Expand Up @@ -3072,7 +3072,12 @@ _ZN4sycl3_V13ext6oneapi12experimental6detail17build_from_sourceERNS0_13kernel_bu
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base11updateValueEPKNS3_14raw_kernel_argEm
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base11updateValueEPKvm
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base14updateAccessorEPKNS0_6detail16AccessorBaseHostE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base16getLocalAccessorEPNS0_7handlerE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base19updateLocalAccessorENS0_5rangeILi3EEE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_base21registerLocalAccessorEPNS0_6detail21LocalAccessorBaseHostEPNS0_7handlerE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_baseC1ENS3_13command_graphILNS3_11graph_stateE0EEE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_baseC1ENS3_13command_graphILNS3_11graph_stateE0EEEmPKv
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_baseC2ENS3_13command_graphILNS3_11graph_stateE0EEE
_ZN4sycl3_V13ext6oneapi12experimental6detail22dynamic_parameter_baseC2ENS3_13command_graphILNS3_11graph_stateE0EEEmPKv
_ZN4sycl3_V13ext6oneapi12experimental6detail24executable_command_graph12finalizeImplEv
_ZN4sycl3_V13ext6oneapi12experimental6detail24executable_command_graph6updateERKNS3_13command_graphILNS3_11graph_stateE0EEE
Expand All @@ -3086,7 +3091,6 @@ _ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph13end_reco
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph15begin_recordingERKSt6vectorINS0_5queueESaIS7_EERKNS0_13property_listE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph15begin_recordingERNS0_5queueERKNS0_13property_listE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph24addGraphLeafDependenciesENS3_4nodeE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph27checkNodePropertiesAndThrowERKNS0_13property_listE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph7addImplERKSt6vectorINS3_4nodeESaIS7_EE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph7addImplERNS3_21dynamic_command_groupERKSt6vectorINS3_4nodeESaIS9_EE
_ZN4sycl3_V13ext6oneapi12experimental6detail24modifiable_command_graph7addImplESt8functionIFvRNS0_7handlerEEERKSt6vectorINS3_4nodeESaISC_EE
Expand Down Expand Up @@ -3248,7 +3252,6 @@ _ZN4sycl3_V16detail13select_deviceERKSt8functionIFiRKNS0_6deviceEEE
_ZN4sycl3_V16detail13select_deviceERKSt8functionIFiRKNS0_6deviceEEERKNS0_7contextE
_ZN4sycl3_V16detail14SubmissionInfo14SecondaryQueueEv
_ZN4sycl3_V16detail14SubmissionInfo17PostProcessorFuncEv
_ZN4sycl3_V16detail14SubmissionInfo9EventModeEv
_ZN4sycl3_V16detail14SubmissionInfoC1Ev
_ZN4sycl3_V16detail14SubmissionInfoC2Ev
_ZN4sycl3_V16detail14addCounterInitERNS0_7handlerERSt10shared_ptrINS1_10queue_implEERS4_IiE
Expand Down Expand Up @@ -3524,14 +3527,14 @@ _ZN4sycl3_V17handler20associateWithHandlerEPNS0_6detail30UnsampledImageAccessorB
_ZN4sycl3_V17handler20memcpyToDeviceGlobalEPKvS3_bmm
_ZN4sycl3_V17handler20setKernelCacheConfigENS1_23StableKernelCacheConfigE
_ZN4sycl3_V17handler20setStateSpecConstSetEv
_ZN4sycl3_V17handler21setKernelWorkGroupMemEm
_ZN4sycl3_V17handler21setUserFacingNodeTypeENS0_3ext6oneapi12experimental9node_typeE
_ZN4sycl3_V17handler22ext_oneapi_fill2d_implEPvmPKvmmm
_ZN4sycl3_V17handler22memcpyFromDeviceGlobalEPvPKvbmm
_ZN4sycl3_V17handler22setHandlerKernelBundleENS0_6kernelE
_ZN4sycl3_V17handler22setHandlerKernelBundleERKSt10shared_ptrINS0_6detail18kernel_bundle_implEE
_ZN4sycl3_V17handler22setKernelClusterLaunchENS0_5rangeILi3EEEi
_ZN4sycl3_V17handler22setKernelIsCooperativeEb
_ZN4sycl3_V17handler21setKernelWorkGroupMemEm
_ZN4sycl3_V17handler24GetRangeRoundingSettingsERmS2_S2_
_ZN4sycl3_V17handler24ext_intel_read_host_pipeENS0_6detail11string_viewEPvmb
_ZN4sycl3_V17handler24ext_oneapi_memcpy2d_implEPvmPKvmmm
Expand Down Expand Up @@ -3725,7 +3728,6 @@ _ZNK4sycl3_V16detail12buffer_plain22get_allocator_internalEv
_ZNK4sycl3_V16detail12buffer_plain7getSizeEv
_ZNK4sycl3_V16detail14SubmissionInfo14SecondaryQueueEv
_ZNK4sycl3_V16detail14SubmissionInfo17PostProcessorFuncEv
_ZNK4sycl3_V16detail14SubmissionInfo9EventModeEv
_ZNK4sycl3_V16detail16AccessorBaseHost11getElemSizeEv
_ZNK4sycl3_V16detail16AccessorBaseHost11getPropListEv
_ZNK4sycl3_V16detail16AccessorBaseHost13isPlaceholderEv
Expand Down

0 comments on commit 075eb00

Please sign in to comment.