-
Notifications
You must be signed in to change notification settings - Fork 751
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CI] Fix shared build on Ubuntu 24 (#16595)
fixes #16502 The problem is that `zstd` installed by default on Ubuntu 24 is built without `-fPIC`. This PR installs `zstd` on Ubuntu 24 docker container by building it from source.
- Loading branch information
1 parent
3b39297
commit 26bbc11
Showing
3 changed files
with
122 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
#!/bin/bash | ||
|
||
# Script to build and install zstd 1.5.6 on Ubuntu 24, with -fPIC flag. | ||
# The default installation of zstd on Ubuntu 24 does not have -fPIC flag | ||
# enabled, which is required for building DPC++ in shared libraries mode. | ||
|
||
# Function to check if the OS is Ubuntu 24 | ||
check_os() { | ||
. /etc/os-release | ||
if [[ "$NAME" != "Ubuntu" || "$VERSION_ID" != "24.04" ]]; then | ||
echo "Warning: This script has only been tested with Ubuntu 24." | ||
fi | ||
} | ||
|
||
# Function to install packages with or without sudo | ||
install_packages() { | ||
if [ "$USE_SUDO" = true ]; then | ||
sudo apt-get update | ||
sudo apt-get install -y build-essential wget | ||
else | ||
apt-get update | ||
apt-get install -y build-essential wget | ||
fi | ||
} | ||
|
||
# Function to uninstall libzstd-dev if installed | ||
uninstall_libzstd_dev() { | ||
if dpkg -l | grep -q libzstd-dev; then | ||
if [ "$USE_SUDO" = true ]; then | ||
sudo apt-get remove -y libzstd-dev | ||
else | ||
apt-get remove -y libzstd-dev | ||
fi | ||
fi | ||
} | ||
|
||
# Function to build a shared library by linking zstd static lib. | ||
# This is used to verify that zstd is built correctly, with -fPIC flag. | ||
build_test_program() { | ||
cat <<EOF > test_zstd.c | ||
#include <zstd.h> | ||
int main() { | ||
ZSTD_CCtx* cctx = ZSTD_createCCtx(); | ||
ZSTD_freeCCtx(cctx); | ||
return 0; | ||
} | ||
EOF | ||
|
||
# Try to use zstd's static library with -fPIC | ||
gcc test_zstd.c -lzstd -fPIC -shared | ||
if [ $? -ne 0 ]; then | ||
echo "zstd installation verification failed." | ||
else | ||
echo "zstd installation verification passed." | ||
fi | ||
|
||
# There won't be a.out file if verification failed. | ||
rm test_zstd.c a.out || true | ||
} | ||
|
||
# Check the OS | ||
check_os | ||
|
||
# Set USE_SUDO to true or false based on your preference | ||
USE_SUDO=true | ||
|
||
# Install necessary build tools | ||
install_packages | ||
|
||
# Uninstall libzstd-dev package if installed | ||
uninstall_libzstd_dev | ||
|
||
# Define the version and URL for zstd | ||
ZSTD_VERSION="1.5.6" | ||
ZSTD_URL="https://github.com/facebook/zstd/releases/download/v$ZSTD_VERSION/zstd-$ZSTD_VERSION.tar.gz" | ||
|
||
# Create a directory for the source code | ||
mkdir -p zstd_build | ||
cd zstd_build | ||
|
||
# Download and extract zstd source code | ||
wget $ZSTD_URL | ||
tar -xzf zstd-$ZSTD_VERSION.tar.gz | ||
cd zstd-$ZSTD_VERSION | ||
|
||
# Build zstd with -fPIC flag. | ||
CFLAGS="-fPIC" CXXFLAGS="-fPIC" make | ||
if [ $? -ne 0 ]; then | ||
echo "Error: make failed." | ||
exit 1 | ||
fi | ||
|
||
# Install zstd. | ||
if [ "$USE_SUDO" = true ]; then | ||
sudo make install | ||
else | ||
make install | ||
fi | ||
if [ $? -ne 0 ]; then | ||
echo "Error: make install failed." | ||
exit 1 | ||
fi | ||
|
||
# Verify zstd installation. | ||
build_test_program | ||
|
||
# Clean up | ||
rm -rf zstd_build |