Skip to content

Commit

Permalink
Update comment and address giga nit
Browse files Browse the repository at this point in the history
  • Loading branch information
mdtoguchi committed Mar 6, 2024
1 parent 77861c9 commit 86cd42c
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions clang/lib/Driver/Driver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6907,13 +6907,13 @@ class OffloadingActionBuilder final {
if (!SB->isValid())
continue;
HA = SB->appendLinkHostActions(DeviceAL);
if (!HA)
continue;
// This created host action has no originating input argument, therefore
// needs to set its offloading kind directly.
if (HA) {
HA->propagateHostOffloadInfo(SB->getAssociatedOffloadKind(),
/*BoundArch=*/nullptr);
Inputs.push_back(HA);
}
HA->propagateHostOffloadInfo(SB->getAssociatedOffloadKind(),
/*BoundArch=*/nullptr);
Inputs.push_back(HA);
}
}

Expand Down Expand Up @@ -7363,7 +7363,10 @@ void Driver::BuildActions(Compilation &C, DerivedArgList &Args,
if (Phase == phases::Link) {
assert(Phase == PL.back() && "linking must be final compilation step.");

// When performing -fsycl-link
// When performing -fsycl-link the current inputs are not expected to
// be passed to the final host link step. Instead, take these inputs
// and redirect them to the associated wrapping step to create the
// final object.
if (C.getInputArgs().hasArg(options::OPT_fsycl_link_EQ) &&
!Args.hasArg(options::OPT_fintelfpga)) {
DeviceAOTLinkerInputs.push_back(Current);
Expand Down

0 comments on commit 86cd42c

Please sign in to comment.