Skip to content

Commit

Permalink
[CI][NFC] Rename use_latest container build argument to `use_unstab…
Browse files Browse the repository at this point in the history
…le_driver` (#16450)

IMO, `use_latest` is confusing - does it mean to use latest docker
container image or latest driver? `use_unstable_driver` would be more
appropriate.
  • Loading branch information
uditagarwal97 authored Dec 20, 2024
1 parent 52015d8 commit ecaab93
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sycl-containers-igc-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
imagefile: ubuntu2404_intel_drivers
tag: devigc
build_args: |
"use_latest=false"
"use_unstable_driver=false"
"use_igc_dev=true"
steps:
- name: Checkout
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/sycl-containers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,22 @@ jobs:
- name: Intel Drivers Ubuntu 22.04 Docker image
file: ubuntu2204_intel_drivers
tag: latest
build_args: "use_latest=false"
build_args: "use_unstable_driver=false"
- name: Intel Drivers Ubuntu 24.04 Docker image
file: ubuntu2404_intel_drivers
tag: latest
build_args: "use_latest=false"
build_args: "use_unstable_driver=false"
- name: Intel Drivers (unstable) Ubuntu 24.04 Docker image
file: ubuntu2404_intel_drivers
tag: unstable
build_args: "use_latest=true"
build_args: "use_unstable_driver=true"
- name: Build + Intel Drivers Ubuntu 22.04 Docker image
file: ubuntu2204_intel_drivers
tag: alldeps
build_args: |
base_image=ghcr.io/intel/llvm/ubuntu2204_build
base_tag=latest
use_latest=false
use_unstable_driver=false
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions devops/containers/ubuntu2204_intel_drivers.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ FROM $base_image:$base_tag

ENV DEBIAN_FRONTEND=noninteractive

ARG use_latest=true
ARG use_unstable_driver=true

USER root

Expand All @@ -18,7 +18,7 @@ COPY dependencies.json /
RUN mkdir /runtimes
ENV INSTALL_LOCATION=/runtimes
RUN --mount=type=secret,id=github_token \
if [ "$use_latest" = "true" ]; then \
if [ "$use_unstable_driver" = "true" ]; then \
install_driver_opt=" --use-latest"; \
else \
install_driver_opt=" dependencies.json"; \
Expand Down
4 changes: 2 additions & 2 deletions devops/containers/ubuntu2404_intel_drivers.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ FROM $base_image:$base_tag

ENV DEBIAN_FRONTEND=noninteractive

ARG use_latest=true
ARG use_unstable_driver=true

USER root

Expand All @@ -18,7 +18,7 @@ COPY dependencies.json /
RUN mkdir /runtimes
ENV INSTALL_LOCATION=/runtimes
RUN --mount=type=secret,id=github_token \
if [ "$use_latest" = "true" ]; then \
if [ "$use_unstable_driver" = "true" ]; then \
install_driver_opt=" --use-latest"; \
else \
install_driver_opt=" dependencies.json"; \
Expand Down

0 comments on commit ecaab93

Please sign in to comment.