Do not generate debug info for declarations in system header files #11544

LU-JOHN · 2023-10-14T06:13:30Z

Add option:

-fno-system-debug Do not emit debug information for declarations in system headers

premanandrao

What happens to template declaration from a system header file, but instantiated in the user file? Are they affected?
Would like to see a few tests for this that shows what would be different for the user.

clang/lib/CodeGen/CGDebugInfo.cpp

… generate debug info Signed-off-by: Lu, John <john.lu@intel.com>

Signed-off-by: Lu, John <john.lu@intel.com>

…ase for this change. Signed-off-by: Lu, John <john.lu@intel.com>

…uarded by a new option. Signed-off-by: Lu, John <john.lu@intel.com>

…bg info for math library functions. Signed-off-by: Lu, John <john.lu@intel.com>

Signed-off-by: Lu, John <john.lu@intel.com>

asudarsa

LGTM. Thanks

asudarsa · 2024-01-11T22:56:18Z

Hi @premanandrao

There have been several changes since your latest comment. Can you please take a look when convenient?

Thanks
Sincerely

premanandrao

LGTM, minor nit.

clang/lib/CodeGen/CGDebugInfo.cpp

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN requested a review from a team as a code owner October 14, 2023 06:13

LU-JOHN marked this pull request as draft October 14, 2023 06:13

LU-JOHN had a problem deploying to WindowsCILock October 14, 2023 06:14 — with GitHub Actions Failure

LU-JOHN temporarily deployed to WindowsCILock October 14, 2023 06:43 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock November 29, 2023 19:28 — with GitHub Actions Failure

LU-JOHN had a problem deploying to WindowsCILock November 29, 2023 21:04 — with GitHub Actions Failure

LU-JOHN force-pushed the no-system-debug branch 2 times, most recently from 528a3eb to cd418b6 Compare December 7, 2023 21:30

LU-JOHN had a problem deploying to WindowsCILock December 7, 2023 21:31 — with GitHub Actions Failure

LU-JOHN temporarily deployed to WindowsCILock December 7, 2023 22:15 — with GitHub Actions Inactive

LU-JOHN force-pushed the no-system-debug branch from b67ca09 to 57467f0 Compare December 9, 2023 06:21

LU-JOHN temporarily deployed to WindowsCILock December 9, 2023 06:22 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock December 9, 2023 07:06 — with GitHub Actions Inactive

LU-JOHN force-pushed the no-system-debug branch from 57467f0 to 82b0a03 Compare December 11, 2023 16:29

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 16:31 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 17:17 — with GitHub Actions Inactive

premanandrao reviewed Dec 11, 2023

View reviewed changes

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 20:49 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 21:32 — with GitHub Actions Inactive

LU-JOHN force-pushed the no-system-debug branch from 423274d to 8eb1932 Compare December 11, 2023 23:15

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 23:16 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock December 11, 2023 23:44 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 05:25 — with GitHub Actions Failure

LU-JOHN temporarily deployed to WindowsCILock December 12, 2023 05:54 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 15:29 — with GitHub Actions Error

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 16:22 — with GitHub Actions Failure

LU-JOHN temporarily deployed to WindowsCILock December 12, 2023 16:52 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 19:50 — with GitHub Actions Failure

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 20:19 — with GitHub Actions Error

LU-JOHN had a problem deploying to WindowsCILock December 12, 2023 20:25 — with GitHub Actions Error

Lu, John added 12 commits January 8, 2024 11:54

Add comment explaining why unreferenced explicit instantiations still…

73f8108

… generate debug info Signed-off-by: Lu, John <john.lu@intel.com>

Rename cc1 option to -fno-system-debug to be same as the driver

e9e7dde

Signed-off-by: Lu, John <john.lu@intel.com>

Do not rely on IsReferenced for Using*Decls. It is not calculated.

132d9a3

Signed-off-by: Lu, John <john.lu@intel.com>

Enhance testcase to also check -fno-system-debug.

94a7f2e

Signed-off-by: Lu, John <john.lu@intel.com>

Apply clang-format

8094f9c

Signed-off-by: Lu, John <john.lu@intel.com>

Windows does not generate debug info for sin. Adapt test to this.

eccdd8b

Signed-off-by: Lu, John <john.lu@intel.com>

Only stop debug generation if -fno-system-debug is used.

b207bea

Signed-off-by: Lu, John <john.lu@intel.com>

Apply clang-format

73ff530

Signed-off-by: Lu, John <john.lu@intel.com>

Debug generation not modified without -fno-system-debug. Update testc…

557fe11

…ase for this change. Signed-off-by: Lu, John <john.lu@intel.com>

Old tests do not need to adapt to this change since all changes are g…

048c1e0

…uarded by a new option. Signed-off-by: Lu, John <john.lu@intel.com>

Do not run debug-sin.cpp on Windows since Windows does not generate d…

7a5c985

…bg info for math library functions. Signed-off-by: Lu, John <john.lu@intel.com>

More cleanly handle different expected mangled names for Linux/Windows.

321c2fd

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN force-pushed the no-system-debug branch from 73b1988 to 321c2fd Compare January 8, 2024 22:59

Explain purpose of test more clearly.

227afc2

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN had a problem deploying to WindowsCILock January 8, 2024 23:02 — with GitHub Actions Failure

LU-JOHN had a problem deploying to WindowsCILock January 8, 2024 23:47 — with GitHub Actions Error

Use correct pre-defined macro.

92c6995

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock January 9, 2024 00:12 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock January 9, 2024 00:58 — with GitHub Actions Inactive

Add driver test

e96307c

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock January 9, 2024 03:33 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock January 9, 2024 04:18 — with GitHub Actions Inactive

asudarsa approved these changes Jan 10, 2024

View reviewed changes

LU-JOHN requested a review from premanandrao January 12, 2024 15:33

premanandrao approved these changes Jan 12, 2024

View reviewed changes

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

Remove unnecessary newlines

7f1c06a

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock January 12, 2024 17:19 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock January 12, 2024 18:59 — with GitHub Actions Inactive

asudarsa merged commit 24255a5 into intel:sycl Jan 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not generate debug info for declarations in system header files #11544

Do not generate debug info for declarations in system header files #11544

LU-JOHN commented Oct 14, 2023 •

edited

Loading

premanandrao left a comment

asudarsa left a comment

asudarsa commented Jan 11, 2024

premanandrao left a comment

Do not generate debug info for declarations in system header files #11544

Do not generate debug info for declarations in system header files #11544

Conversation

LU-JOHN commented Oct 14, 2023 • edited Loading

premanandrao left a comment

Choose a reason for hiding this comment

asudarsa left a comment

Choose a reason for hiding this comment

asudarsa commented Jan 11, 2024

premanandrao left a comment

Choose a reason for hiding this comment

LU-JOHN commented Oct 14, 2023 •

edited

Loading