Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Doc] Add support for OpenCL queries #11994

Closed
wants to merge 4 commits into from
Closed

[SYCL][Doc] Add support for OpenCL queries #11994

wants to merge 4 commits into from

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Nov 23, 2023

Add additional APIs to the OpenCL kernel compiler specification, which allow the application to query the OpenCL features and extensions that are supported.

@gmlueck
[SYCL][Doc] Add support for OpenCL queries
f270fc7 
Add additional APIs to the OpenCL kernel compiler specification, which
allow the application to query the OpenCL features and extensions that
are supported.
@gmlueck gmlueck requested a review from a team as a code owner November 23, 2023 13:31
@gmlueck
Copy link
Contributor Author

gmlueck commented Nov 23, 2023

@densamoilov: This PR adds the queries you requested in #11331. Please let me know if this satisfies your requirements.

@densamoilov
Copy link

@densamoilov: This PR adds the queries you requested in #11331. Please let me know if this satisfies your requirements.

The API looks good to me.

@gmlueck gmlueck requested a review from Pennycook December 20, 2023 19:07
@gmlueck gmlueck marked this pull request as draft December 20, 2023 19:24
@gmlueck
Copy link
Contributor Author

gmlueck commented Dec 21, 2023

We should treat this PR as approved and ready for implementation.

I'm marking it "draft" only because I don't want it to be merged until after it is implemented. This is a new process I'm trying out for PRs that change an extension spec that is already implemented. (We want these extension specs to reflect that actual implemented behavior, which is why we don't want to merge changes that describe features that aren't implemented yet.)

@gmlueck
Queries return false when opencl not supported
f07871f 
Clarify the return value of the queries when the device does not
support the OpenCL C language at all.
@cperkinsintel cperkinsintel mentioned this pull request Mar 1, 2024
Merged
steffenlarsen pushed a commit that referenced this pull request Mar 7, 2024
@cperkinsintel @gmlueck
[SYCL] kernel_compiler support of OpenCL queries (#12888)
6344ead 
This PR both includes and realizes the new specification here originally
drafted here: #11994

---------

Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
@gmlueck
Copy link
Contributor Author

gmlueck commented Mar 7, 2024

Closing this because the spec change was included in #12888.

@gmlueck gmlueck closed this Mar 7, 2024
@gmlueck gmlueck deleted the gmlueck/kernel-compiler-opencl-queries branch March 7, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@densamoilov densamoilov densamoilov left review comments

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@Pennycook Pennycook Pennycook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmlueck @densamoilov @Pennycook @cperkinsintel