[SYCL] add preliminary support for bfloat16 to sycl::vec #12261

cperkinsintel · 2023-12-28T23:25:53Z

This does not yet add support for the math builtins for sycl::vec<bfloat16> . That will come later.

github-actions · 2023-12-28T23:35:23Z

✅ With the latest revision this PR passed the C/C++ code formatter.

dkhaldi · 2024-01-19T15:23:23Z

Does this change enable sub_group::load and sub_group::store (https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/sub_group.hpp#L71) to work on bfloat16 type?
If yes, it will be good to add an example of these two instructions in one of the tests you added.

cperkinsintel · 2024-01-19T18:59:09Z

@dkhaldi - I did a quick test of using sub_groups to .load() data from one buffer and modify and .store() it into another, and this works with bfloat16 in the current source base. So, if you are asking if this PR would enable that behavior, the answer is "no" - it's already present and working. AFAICT.

But maybe I'm misunderstanding your inquiry?

I also checked using sub_groups to .load()/.store() for sycl::vec<bfloat16> and that now compiles and works with this PR, whereas before it, it would not (obviously). Are you sure we need testing for this? I strongly suspect the contexts of your inquiry and my answer are not the same.

dkhaldi · 2024-01-19T20:21:07Z

I also checked using sub_groups to .load()/.store() for sycl::vec<bfloat16> and that now compiles and works with this PR, whereas before it, it would not (obviously). Are you sure we need testing for this? I strongly suspect the contexts of your inquiry and my answer are not the same.

Sorry I was not specific, Yes, I meant this latter. sub_group::load/store on sycl::vec of type bfloat16.
Good to know that your PR enables that.
I think it will be good to add that in the test since your PR enables it.

sycl/include/sycl/detail/generic_type_lists.hpp

sycl/include/sycl/detail/generic_type_traits.hpp

sycl/include/sycl/ext/oneapi/bfloat16.hpp

sycl/include/sycl/stream.hpp

sycl/test-e2e/BFloat16/bfloat16_vec.cpp

aelovikov-intel

Looks much better now, but I've had too many iterations reviewing this that some things might have become invisible to my eye. @steffenlarsen , @sergey-semenov , would you mind having a look through it as well?

cperkinsintel · 2024-01-24T18:04:54Z

@intel/dpcpp-tools-reviewers could I get one of you to review?

dkhaldi

LGTM

AlexeySachkov

Not sure why bfloat16 E2E test are owned by tools team, but changes LGTM

steffenlarsen · 2024-01-25T14:47:45Z

sycl/include/sycl/types.hpp

@@ -142,20 +144,61 @@ using select_apply_cl_t = std::conditional_t<
 template <typename T> struct vec_helper {
  using RetType = T;
  static constexpr RetType get(T value) { return value; }
+  static constexpr RetType set(T value) { return value; }


Nit; I am not much for the name "set". What does it set? "get" isn't great for that matter, but it sounds more and more like we are mutating something, which we are not.

steffenlarsen · 2024-01-25T14:49:47Z

sycl/include/sycl/types.hpp

    return std::array<DataT_, 1>{vec_data<DataT_>::get(static_cast<DataT_>(A))};
-#else
-    return std::array<DataT_, 1>{vec_data<DataT_>::get(A)};
-#endif


Is there a reason we can promote this out of preview now? Was it just a mistake to have it under preview before?

Correct. It was a mistake and shouldn't have been there to begin with.

cperkinsintel added 4 commits December 11, 2023 19:43

Bfloat16 support for sycl::vec

1e61fe3

remove stray comment

1088186

fixes and tests

12a3a60

clang-format declares its love for me

c04090a

clang-format thirsts

19f1f22

cperkinsintel had a problem deploying to WindowsCILock December 28, 2023 23:45 — with GitHub Actions Failure

cperkinsintel added 2 commits December 29, 2023 08:43

Merge branch 'sycl' into cperkins-vec-support-bfloat16-pr

16973c1

missing include

3f07e16

cperkinsintel had a problem deploying to WindowsCILock December 29, 2023 17:01 — with GitHub Actions Failure

cperkinsintel added 2 commits December 29, 2023 12:50

win build fix

b260df1

clang-formattery

afd4e7b

cperkinsintel had a problem deploying to WindowsCILock December 29, 2023 21:00 — with GitHub Actions Failure

cperkinsintel had a problem deploying to WindowsCILock December 29, 2023 21:33 — with GitHub Actions Failure

correct test directives

2d4efae

cperkinsintel had a problem deploying to WindowsCILock December 29, 2023 22:34 — with GitHub Actions Failure

cperkinsintel had a problem deploying to WindowsCILock December 29, 2023 23:06 — with GitHub Actions Failure

working around constexpr casting limitations

fec9977

cperkinsintel temporarily deployed to WindowsCILock January 2, 2024 19:28 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock January 2, 2024 20:00 — with GitHub Actions Inactive

blind fix for CUDA. Unable to reproduce locallly

08db12c

cperkinsintel temporarily deployed to WindowsCILock January 3, 2024 17:04 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock January 3, 2024 17:36 — with GitHub Actions Inactive

cperkinsintel marked this pull request as ready for review January 3, 2024 19:47

cperkinsintel requested review from a team as code owners January 3, 2024 19:47

cperkinsintel requested a review from aelovikov-intel January 3, 2024 19:47

update to test after discussion

207db79

cperkinsintel temporarily deployed to WindowsCILock January 3, 2024 20:09 — with GitHub Actions Inactive

cperkinsintel added 2 commits January 9, 2024 11:22

Merge branch 'sycl' into cperkins-vec-support-bfloat16-pr

563610c

using sycl::bit_cast when possible

d04dcaa

cperkinsintel temporarily deployed to WindowsCILock January 9, 2024 19:44 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock January 9, 2024 20:17 — with GitHub Actions Inactive

cperkinsintel requested a review from aelovikov-intel January 9, 2024 22:25

remove bfloat16 from geo lists

7edd97e

cperkinsintel temporarily deployed to WindowsCILock January 18, 2024 20:05 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock January 18, 2024 21:13 — with GitHub Actions Inactive

aelovikov-intel reviewed Jan 19, 2024

View reviewed changes

sycl/include/sycl/detail/generic_type_lists.hpp Outdated Show resolved Hide resolved

aelovikov-intel reviewed Jan 19, 2024

View reviewed changes

cperkinsintel added 4 commits January 22, 2024 15:22

reviewer feedback

7cc4e0b

Merge branch 'sycl' into cperkins-vec-support-bfloat16-pr

99d2f76

reviewer feedback

a4d144e

additional testing for sub_group .load()/.store()

2809c37

cperkinsintel temporarily deployed to WindowsCILock January 23, 2024 00:48 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock January 23, 2024 01:18 — with GitHub Actions Inactive

cperkinsintel requested review from aelovikov-intel and dkhaldi January 23, 2024 16:46

aelovikov-intel approved these changes Jan 24, 2024

View reviewed changes

aelovikov-intel requested review from sergey-semenov and steffenlarsen January 24, 2024 17:39

dkhaldi approved these changes Jan 24, 2024

View reviewed changes

AlexeySachkov approved these changes Jan 25, 2024

View reviewed changes

steffenlarsen reviewed Jan 25, 2024

View reviewed changes

againull merged commit bbbe883 into intel:sycl Jan 25, 2024

AlexeySachkov mentioned this pull request Mar 18, 2024

Enable vec class for bfloat16 #6436

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] add preliminary support for bfloat16 to sycl::vec #12261

[SYCL] add preliminary support for bfloat16 to sycl::vec #12261

cperkinsintel commented Dec 28, 2023

github-actions bot commented Dec 28, 2023 •

edited

Loading

dkhaldi commented Jan 19, 2024

cperkinsintel commented Jan 19, 2024

dkhaldi commented Jan 19, 2024

aelovikov-intel left a comment

cperkinsintel commented Jan 24, 2024

dkhaldi left a comment

AlexeySachkov left a comment

steffenlarsen Jan 25, 2024

steffenlarsen Jan 25, 2024

cperkinsintel Jan 25, 2024

[SYCL] add preliminary support for bfloat16 to sycl::vec #12261

[SYCL] add preliminary support for bfloat16 to sycl::vec #12261

Conversation

cperkinsintel commented Dec 28, 2023

github-actions bot commented Dec 28, 2023 • edited Loading

dkhaldi commented Jan 19, 2024

cperkinsintel commented Jan 19, 2024

dkhaldi commented Jan 19, 2024

aelovikov-intel left a comment

Choose a reason for hiding this comment

cperkinsintel commented Jan 24, 2024

dkhaldi left a comment

Choose a reason for hiding this comment

AlexeySachkov left a comment

Choose a reason for hiding this comment

steffenlarsen Jan 25, 2024

Choose a reason for hiding this comment

steffenlarsen Jan 25, 2024

Choose a reason for hiding this comment

cperkinsintel Jan 25, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 28, 2023 •

edited

Loading