-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][ESIMD] Introduce rdtsc API #12315
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
// RUN: %{build} -o %t.out | ||
// RUN: %{run} %t.out | ||
//==- rdtsc.cpp - Test to verify rdtsc0 and sr0 functionlity----------------==// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
// This is basic test to validate rdtsc function. | ||
|
||
#include <cmath> | ||
#include <iostream> | ||
#include <sycl/ext/intel/esimd.hpp> | ||
#include <sycl/ext/intel/esimd/simd.hpp> | ||
#include <sycl/sycl.hpp> | ||
#include <vector> | ||
|
||
int ErrCnt = 0; | ||
template <typename DataT> | ||
using shared_allocator = sycl::usm_allocator<DataT, sycl::usm::alloc::shared>; | ||
template <typename DataT> | ||
using shared_vector = std::vector<DataT, shared_allocator<DataT>>; | ||
|
||
int test_rdtsc_sr0() { | ||
sycl::queue Queue; | ||
shared_allocator<uint64_t> Allocator(Queue); | ||
constexpr int32_t SIZE = 32; | ||
|
||
shared_vector<uint64_t> VectorOutputRDTSC(SIZE, -1, Allocator); | ||
|
||
auto GlobalRange = sycl::range<1>(SIZE); | ||
sycl::range<1> LocalRange{1}; | ||
sycl::nd_range<1> Range(GlobalRange, LocalRange); | ||
|
||
{ | ||
Queue.submit([&](sycl::handler &cgh) { | ||
uint64_t *VectorOutputRDTSCPtr = VectorOutputRDTSC.data(); | ||
|
||
auto Kernel = ([=](sycl::nd_item<1> ndi) [[intel::sycl_explicit_simd]] { | ||
using namespace sycl::ext::intel::esimd; | ||
auto Idx = ndi.get_global_id(0); | ||
simd<uint64_t, SIZE> DummyVector; | ||
uint64_t StartCounter = sycl::ext::intel::experimental::esimd::rdtsc(); | ||
DummyVector.copy_from(VectorOutputRDTSCPtr); | ||
uint64_t EndCounter = sycl::ext::intel::experimental::esimd::rdtsc(); | ||
|
||
simd<uint64_t, 1> VectorResultRDTSC = EndCounter - StartCounter; | ||
v-klochkov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
VectorResultRDTSC.copy_to(VectorOutputRDTSCPtr + Idx); | ||
}); | ||
|
||
cgh.parallel_for(Range, Kernel); | ||
}); | ||
Queue.wait(); | ||
} | ||
|
||
int Result = 0; | ||
|
||
// Check if returned values are positive | ||
Result |= std::any_of(VectorOutputRDTSC.begin(), VectorOutputRDTSC.end(), | ||
[](uint64_t v) { return v <= 0; }); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If it will be signed there will be risk of overflow. I reworked the logic to reduce the chances of overflow There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If suppose 2Ghz, then 2 secs = 32-bit. the timestamp returns 64-bit, which is huge (2 sec * 4Bil, so, there was no risk of overflow). The updated solution is good, except it needs 1 minor fix to avoid DCE-ing the load between rdtsc calls. |
||
|
||
return Result; | ||
} | ||
|
||
int main() { | ||
|
||
int TestResult = 0; | ||
|
||
TestResult |= test_rdtsc_sr0(); | ||
|
||
if (!TestResult) { | ||
std::cout << "Pass" << std::endl; | ||
} | ||
return TestResult; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rdtsc stands for ReaD TimeStamp Counter (I think). Can you please make it more clear in the comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GenX returns 4 integers (which is probably the content of the drtsc register (if it is a register).
The function only returns uint64 (part of what GenX can return), please don't use the word register in this decription.