[syclcompat][CUDA] FIX UB in test / seq_cst requires sm_70 on CUDA. #12575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI device is >= sm_70 so can use seq_cst. However this test did not compile for >=sm_70. Test execution is also UB unless using a single_task. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
See #12516 (comment) for details of the UB and its fix. This PR is blocking #12516 |
Alcpz
approved these changes
Feb 1, 2024
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UB in test by using a single thread task.
A shared USM variable was being simultaneously written to by multiple threads without using atomics. AFAIK this is generally not a well defined program, and was leading to invalid values.
seq_cst also requires sm_70 on CUDA, so the compilation invocation is updated to reflect this.
The CI device is >= sm_70 so it can use seq_cst. However this test did not compile for >=sm_70.