Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Matrix] Correct Prefetch instruction usage #12623

Merged
merged 2 commits into from
Feb 8, 2024
Merged

[SYCL][Matrix] Correct Prefetch instruction usage #12623

merged 2 commits into from
Feb 8, 2024

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Feb 6, 2024

No description provided.

@MrSidims
[SYCL][Matrix] Correct Prefetch instruction name
c6f1357 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims MrSidims requested review from a team as code owners February 6, 2024 15:46
@MrSidims MrSidims requested a review from maarquitos14 February 6, 2024 15:46
@MrSidims
fix prefetch
c9a699f 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
maarquitos14
maarquitos14 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MrSidims MrSidims changed the title [SYCL][Matrix] Correct Prefetch instruction name [SYCL][Matrix] Correct Prefetch instruction usage Feb 6, 2024
dkhaldi
dkhaldi approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

MrSidims
MrSidims commented Feb 7, 2024
View reviewed changes
Copy link
Contributor Author

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't pushed another change, sorry, wait a bit

@MrSidims MrSidims marked this pull request as draft February 7, 2024 18:43
@sarnex
Copy link
Contributor

sarnex commented Feb 7, 2024

Oh my god that was so close
image

@MrSidims MrSidims marked this pull request as ready for review February 7, 2024 18:45
@MrSidims MrSidims requested a review from dkhaldi February 7, 2024 18:45
dkhaldi
dkhaldi approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffenlarsen
Copy link
Contributor

ESIMD/aot_mixed.cpp should have been fixed with #12650. @MrSidims - Is this ready for merging?

@MrSidims
Copy link
Contributor Author

MrSidims commented Feb 8, 2024

@steffenlarsen yes, thanks for checking!

@steffenlarsen steffenlarsen merged commit 0eac618 into intel:sycl Feb 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@dkhaldi dkhaldi dkhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MrSidims @sarnex @steffenlarsen @dkhaldi @maarquitos14