[SYCL] Correct handling of enumeration specialization constants #12925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower enumeration specialization constants to `SpecConstant` in SPIR-V instead of `SpecConstantComposite`, thus handling them using their underlying integral types. Signed-off-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
commented
Mar 6, 2024
victor-eds
commented
Mar 6, 2024
|
This handles #12703 |
|
@AlexeySachkov following on our conversation in #12703. Can you take a look at my proposed solution? |
victor-eds
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@victor-eds the pre-commit failure is known and has been reported already in #12791. I don't think it's related to your changes. |
AlexeySachkov
approved these changes
Mar 7, 2024
|
Windows CI failure unrelated. |
|
Unrelated failure in post-commit reported here: #12956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower enumeration specialization constants to
SpecConstantin SPIR-V instead ofSpecConstantComposite, thus handling them using their underlying integral types.