[SYCL][NATIVECPU] Point oneAPI Construction Kit tag to main branch #12940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
reviewed
Mar 7, 2024
| @@ -23,32 +23,67 @@ add_sycl_plugin(native_cpu | |||
| UnifiedRuntimeCommon | |||
| ) | |||
|
|
|||
| option(OCK_SOURCE_DIR "Root to a local checkout of the oneAPI Construction Kit" "") | |||
| option(OCK_GIT_REPO "Git repository for the oneAPI Construction Kit FetchContent" "") | |||
There was a problem hiding this comment.
I thought option was for a boolean variable https://cmake.org/cmake/help/latest/command/option.html
There was a problem hiding this comment.
Thanks, I wasn't really aware of that, I changed the non-bool ones to use set().
uwedolinsky
approved these changes
Mar 8, 2024
|
@intel/llvm-gatekeepers this looks ready to get merged, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the git tag for the oneAPI Construction Kit, pointing to a commit in the
mainbranch. It also adds CMake variables to either use a local checkout of the OCK, or overwrite the git repo/tag used byFetchContent.