-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E] Remove use of distutils package #12943
Conversation
There's a lit-specific |
Ah nice thanks, I didn't see that one. I'm not sure which is preferable, to be honest. I'm happy to take suggestions. I see there's prior art in migrating to |
ping |
This package is deprecated and removed in python 3.12. PEP 632 recommends replacing distutils.spawn.find_executable with shutils.which, which should offer the same functionality. Also remove another python module which appears unused.
@sergey-semenov @aelovikov-intel @steffenlarsen Please review this patch. It's stale for a month now. |
e6d65aa
to
ad69573
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not seeing the previous ping! Feel free to ping more frequently and/or tag specific people, like @ldrumm did.
Looks like a good change. 👍
This package is deprecated and removed in python 3.12. PEP 632 recommends replacing
distutils.spawn.find_executable
withshutils.which
, which should offer the same functionality.Also remove another python module which appears unused.