Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Remove use of distutils package #12943

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

frasercrmck
Copy link
Contributor

This package is deprecated and removed in python 3.12. PEP 632 recommends replacing distutils.spawn.find_executable with shutils.which, which should offer the same functionality.

Also remove another python module which appears unused.

@frasercrmck frasercrmck requested a review from a team as a code owner March 7, 2024 16:00
@ldrumm
Copy link
Contributor

ldrumm commented Mar 7, 2024

There's a lit-specific lit.util.which that you might find useful since it uses an explicit environment: https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/util.py#L228

@frasercrmck
Copy link
Contributor Author

There's a lit-specific lit.util.which that you might find useful since it uses an explicit environment: https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/lit/util.py#L228

Ah nice thanks, I didn't see that one.

I'm not sure which is preferable, to be honest. I'm happy to take suggestions.

I see there's prior art in migrating to shutil.which (01fdc2a) though admittedly it wraps it to account for .exe files - which I don't think lit.util.which would do either.

@frasercrmck
Copy link
Contributor Author

ping

This package is deprecated and removed in python 3.12. PEP 632
recommends replacing distutils.spawn.find_executable with shutils.which,
which should offer the same functionality.

Also remove another python module which appears unused.
@ldrumm
Copy link
Contributor

ldrumm commented Apr 9, 2024

@sergey-semenov @aelovikov-intel @steffenlarsen

Please review this patch. It's stale for a month now.

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not seeing the previous ping! Feel free to ping more frequently and/or tag specific people, like @ldrumm did.

Looks like a good change. 👍

@ldrumm ldrumm merged commit f12a19d into intel:sycl Apr 9, 2024
11 of 12 checks passed
@frasercrmck frasercrmck deleted the remove-sycl-distutils branch April 9, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants