Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRIVER][SYCL] Update the SYCL triple parsing for AMD #15990

Merged
merged 8 commits into from
Dec 18, 2024
Merged

[DRIVER][SYCL] Update the SYCL triple parsing for AMD #15990

merged 8 commits into from
Dec 18, 2024

Conversation

jle-quel
Copy link
Contributor

@jle-quel jle-quel commented Nov 5, 2024 •
edited
Loading

Description

This PR improves the SYCL target triple parsing for AMD GPUs by enforcing that the triple must be fully specified and explicit.

@jle-quel jle-quel requested a review from a team as a code owner November 5, 2024 15:11
@jle-quel jle-quel requested a review from a team November 7, 2024 10:58
@jle-quel jle-quel requested a review from a team as a code owner December 3, 2024 09:36
keryell
keryell approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Could you rewrite sycl → SYCL in the PR title since it will be used as the commit message?

@jle-quel jle-quel changed the title [DRIVER][SYCL] Update the sycl triple parsing for AMD [DRIVER][SYCL] Update the SYCL triple parsing for AMD Dec 4, 2024
@jle-quel jle-quel requested a review from a team December 18, 2024 08:17
@sommerlukas
Copy link
Contributor

@intel/dpcpp-doc-reviewers This PR still needs review from you. As far as I can see, it's a single line addition to UserManual.md that needs you approval.

@bader bader merged commit ca955e5 into intel:sycl Dec 18, 2024
15 checks passed
@jle-quel jle-quel deleted the jle-quel/driver-parsing branch December 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@srividya-sundaram srividya-sundaram srividya-sundaram approved these changes

@keryell keryell keryell approved these changes

@bader bader bader approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jle-quel @sommerlukas @bader @keryell @srividya-sundaram @mdtoguchi