[SYCL][Devops] Fix DockerFile linting issues discovered by trivy
#16411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://avd.aquasec.com/misconfig/ds017 Docker best practices says that running `update` and `install` commands separately may lead to situations where Docker skips `update` step and re-uses cache leading to outdated versions of packages being installed.
See https://avd.aquasec.com/misconfig/ds002 Made it so that the last `USER` command in `base` and `build` is not `root`.
See https://avd.aquasec.com/misconfig/ds002 Made it so our docker files have at least one `USER` command which is not `root`.
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Note for reviewers: whilst I'm troubleshooting issues with container builds, I'm cancelling all other affected workflows. Once this patch is ready for review and I receive some feedback, I will do a full CI run with all checks to make sure that my workflow changes don't cause any issues. |
sarnex
approved these changes
Dec 18, 2024
sarnex
reviewed
Dec 18, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Dec 19, 2024
|
@bader @steffenlarsen Doc overlords, can someone take a look? Thanks! Need to make some Docker changes soon, so having this PR in will make merge simpler. |
bader
reviewed
Dec 19, 2024
AlexeySachkov
commented
Dec 19, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
approved these changes
Dec 19, 2024
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
deleted the
private/asachkov/apply-docker-best-practices
branch
AlexeySachkov
added a commit
that referenced
this pull request
Dec 20, 2024
Apparently, I overlooked part of the documentation saying that docker secrets are only available for containers running as a service which isn't the case for our build/test CI pipeline. Therefore, I'm partially reverting #16411 so that our containers once again use `sycl` user which has password-less `sudo` access. This PR also reverts #16436 to re-enable GPU reset.
AlexeySachkov
added a commit
that referenced
this pull request
Dec 20, 2024
Apparently, I overlooked part of the documentation saying that docker secrets are only available for containers running as a service which isn't the case for our build/test CI pipeline. Therefore, I'm partially reverting #16411 so that our containers once again use `sycl` user which has password-less `sudo` access. This PR also reverts #16436 to re-enable GPU reset.
sarnex
pushed a commit
that referenced
this pull request
Dec 20, 2024
Apparently, I overlooked part of the documentation saying that docker secrets are only available for containers running as a service which isn't the case for our build/test CI pipeline. Therefore, I'm partially reverting #16411 so that our containers once again use `sycl` user which has password-less `sudo` access. This PR also reverts #16436 to re-enable GPU reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submit of #16290 with fixes from #16324 and some more extra changes.
Issues addressed:
See https://avd.aquasec.com/misconfig/ds017
See https://avd.aquasec.com/misconfig/ds002
Issues remaining:
See https://avd.aquasec.com/misconfig/ds026
I didn't add
HEALTHCHECKcommand to our containers, because I don't know if that makes sense and which command to launch. I.e. our containers they only provide some pre-installed tools, but they don't launch any services which we could check.User creation was outlined into a separate helper script. Our containers only come with
sycl_ciuser now which requires a password to usesudo. However, it is still possible to get the originalsycluser for those who uses that container locally and needssudoaccess.