Skip to content

[SYCL] Properties must be a properties list in group_load/store #16422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aelovikov-intel
Copy link
Contributor

Before this patch we were failing with more obscure errors like

no member named 'has_property' in ...property_value<...data_placement_key...>

Before this patch we were failing with more obscure errors like

```
no member named 'has_property' in ...property_value<...data_placement_key...>
```
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specification and implementation changes LGTM.

@aelovikov-intel aelovikov-intel merged commit 15929c6 into intel:sycl Dec 23, 2024
15 checks passed
@aelovikov-intel aelovikov-intel deleted the load_store_properties_constraint branch December 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants