-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add remaining Ubuntu 24.04 Dockerfile #16457
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7496edb
[CI] Add remaining Ubuntu 24.04 Docker containers
sarnex 97ab443
split doc into sections
sarnex f9dd4ce
Update sycl/doc/developer/DockerBKMs.md
sarnex 5c2d9fa
Update sycl/doc/developer/DockerBKMs.md
sarnex 9e0c85b
Update sycl/doc/developer/DockerBKMs.md
sarnex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
FROM nvidia/cuda:12.6.3-devel-ubuntu24.04 | ||
|
||
ENV DEBIAN_FRONTEND=noninteractive | ||
|
||
USER root | ||
|
||
# Install SYCL prerequisites | ||
COPY scripts/install_build_tools.sh /install.sh | ||
RUN /install.sh | ||
|
||
SHELL ["/bin/bash", "-ec"] | ||
|
||
# Make the directory if it doesn't exist yet. | ||
# This location is recommended by the distribution maintainers. | ||
RUN mkdir --parents --mode=0755 /etc/apt/keyrings | ||
# Download the key, convert the signing-key to a full | ||
# keyring required by apt and store in the keyring directory | ||
RUN wget https://repo.radeon.com/rocm/rocm.gpg.key -O - | \ | ||
gpg --dearmor | tee /etc/apt/keyrings/rocm.gpg > /dev/null && \ | ||
# Add rocm repo | ||
echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/amdgpu/6.3/ubuntu noble main" \ | ||
| tee /etc/apt/sources.list.d/amdgpu.list && \ | ||
echo "deb [arch=amd64 signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/rocm/apt/6.3 noble main" \ | ||
| tee --append /etc/apt/sources.list.d/rocm.list && \ | ||
echo -e 'Package: *\nPin: release o=repo.radeon.com\nPin-Priority: 600' \ | ||
| tee /etc/apt/preferences.d/rocm-pin-600 && \ | ||
echo -e 'Package: *\nPin: release o=repo.radeon.com\nPin-Priority: 600' \ | ||
| tee /etc/apt/preferences.d/rocm-pin-600 | ||
# Install the ROCM kernel driver | ||
RUN apt update && apt install -yqq rocm-dev && \ | ||
apt-get clean && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
COPY scripts/create-sycl-user.sh /user-setup.sh | ||
RUN /user-setup.sh | ||
|
||
COPY scripts/docker_entrypoint.sh /docker_entrypoint.sh | ||
|
||
USER sycl | ||
|
||
ENTRYPOINT ["/docker_entrypoint.sh"] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ubuntu 22 docker container uses CUDA 12.1.0 (https://github.com/intel/llvm/blob/sycl/devops/containers/ubuntu2204_build.Dockerfile#L1). Are we good to use CUDA 12.6.3 with DPC++?
Similarly, Ubuntu 22 container uses ROCM 6.1.1 while Ubuntu 24 uses ROCM 6.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Based on the Codeplay doc (who owns the AMD/NVidia support), they say CUDA12+ works but isn't the version they are currently testing on:
And for ROCM:
Here it doesn't list 6.3 specifically but says a wide variety should work. Also one of the runners is already using an unsupported GPU so it's not like we are following this doc today.
So IMO based on the doc I think it's fine to try to use the newer API versions but we can revert if there's some problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. @npmiller @JackAKirk FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this for now. This PR doesn't make us use the new versions in testing yet, it just adds the Docker images. There will be a subsequent PR to move the CI over to use those new images. Happy to address any feedback from the Codeplay team.