[DevMSAN] Fix missed symbols __msan_memset & __msan_warning #16477
+167
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
reviewed
Dec 26, 2024
llvm/test/Instrumentation/MemorySanitizer/SPIRV/check_large_access_size.ll
Outdated
Show resolved
Hide resolved
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
reviewed
Dec 26, 2024
libdevice/sanitizer/msan_rtl.cpp
Outdated
Comment on lines
208
to
210
| MSAN_MEMSET(0); | ||
| MSAN_MEMSET(1); | ||
| MSAN_MEMSET(3); |
There was a problem hiding this comment.
Suggested change
| MSAN_MEMSET(0); | |
| MSAN_MEMSET(1); | |
| MSAN_MEMSET(3); | |
| MSAN_MEMSET(0) | |
| MSAN_MEMSET(1) | |
| MSAN_MEMSET(3) |
AllanZyne
reviewed
Dec 26, 2024
| const std::string Suffix = "_p" + itostr(FirstArgAS); | ||
| PointerType *FirstArgPtrTy = IRB.getPtrTy(FirstArgAS); | ||
| MemsetOffloadFn[FirstArgAS] = M.getOrInsertFunction( | ||
| "__msan_memset" + Suffix, TLI.getAttrList(C, {1}, true), |
There was a problem hiding this comment.
Suggested change
| "__msan_memset" + Suffix, TLI.getAttrList(C, {1}, true), | |
| "__msan_memset" + Suffix, TLI.getAttrList(C, {1}, /*Signed=*/true), |
AllanZyne
reviewed
Dec 26, 2024
Comment on lines
+17
to
+19
| sycl::range<1>{2}, [=](sycl::id<1> ID) { | ||
| B[ID] = sycl::int3{(sycl::int3)ID[0]} / B[ID]; | ||
| }); |
There was a problem hiding this comment.
It's hard to construct a stable memset test since the call to memset is insert by compiler.
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
zhaomaosu
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.