[SYCL] Provide length when converting to string view in preview mode#19212
Closed
jchlanda wants to merge 2 commits intointel:syclfrom
Closed
[SYCL] Provide length when converting to string view in preview mode#19212jchlanda wants to merge 2 commits intointel:syclfrom
jchlanda wants to merge 2 commits intointel:syclfrom
Conversation
Contributor
Author
|
This was discovered in RTC testing and was triggered from within |
Contributor
Author
|
Looks like |
jchlanda
force-pushed
the
jakub/string_view
branch
from
a9bb064 to
73a89c4
Compare
aelovikov-intel
suggested changes
Jun 30, 2025
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
Why is existing data member len wrong?
Contributor
Author
You're right, that was a knee-jerk reaction to a different problem. Closing now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.