[SYCL][Driver] Respect -nocudalib again after bad merge conflict resolution#19216
Merged
aelovikov-intel merged 3 commits intointel:syclfrom Jul 2, 2025
Merged
[SYCL][Driver] Respect -nocudalib again after bad merge conflict resolution#19216aelovikov-intel merged 3 commits intointel:syclfrom
aelovikov-intel merged 3 commits intointel:syclfrom
Conversation
…lution fc26ef4 is a bad resolution `--offloadlib` is a positive option to explicitly link offload device libraries (usually on by default), while the option it replaced (`-nogpulib`) was the negative option to disable linking them. To behave correctly, we need to consider both positive and negative options. The test did not catch this because the filecheck CHECK-NOT directive had a typo. Fix that as well.
srividya-sundaram
approved these changes
Jun 30, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fc26ef4cf0cafce381395f2d422bff33227e80b8 is a bad resolution
--offloadlibis a positive option to explicitly link offload device libraries (usually on by default), while the option it replaced (-nogpulib) was the negative option to disable linking them.To behave correctly, we need to consider both positive and negative options.
The test did not catch this because the filecheck CHECK-NOT directive had a typo. Fix that as well.