[UR][L0v2] Restore code that differentiates... #20114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
host and device buffers.
|
Why? This was originally disabled because the integrated buffer implementation doesn't work well. |
There's an issue (URLZA-651) with test that checks what kind of memory is being allocated depending on the type of device being used - https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/Basic/buffer/buffer_create.cpp. Since this code was disabled ~4 months ago, I wanted to check whether the current buffer implementation satisfies the UR/e2e tests. |
|
Closed in favor of: #20122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host and device buffers.