This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Check criterion numerical value validity if it is inclusive #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of Inclusive Criterion, its appropriate numerical value may be equal to the addition of several values which results to non valid numerical values. This patch checks the criterion value validity of inclusive criterions. Signed-off-by: Chokri ZAGROUBA <chokrix.zagrouba@intel.com>
|
This pull request has been pending for a long time. What is the requirement fullfiled by it ? Why is a new public api added ? Is their still a need for it ? |
|
I will close this PR in a couple of weeks if their is no answer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of Inclusive Criterion, its appropriate numerical value may
be equal to the addition of several values which results to non valid
numerical values.
This patch checks the criterion value validity of inclusive criterions.
Coverage increased (+0.02%) to 70.15% when pulling cc33fa2 on zchokri:master into 9d1bcf0 on 01org:master.