This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
[WIP] Allow setting boolean parameter with "true" and "false" #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
force-pushed
the
use-convertto-for-boolean-parameter
branch
3 times, most recently
from
9d71f55
to
e17178c
Compare
krocard
changed the title
krocard
force-pushed
the
use-convertto-for-boolean-parameter
branch
2 times, most recently
from
c66e4b8
to
95daa50
Compare
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
convertTo<bool> now allow 0x0 and 0x1 as input. It was inconsistant with the other types. Do that by converting the string to uint8_t and then testing for 0 or 1. Also do a case insensitive comparison for "true" and "false". Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Instead of hard coding specific values a boolean
can take, use covertTo.
This means a lot of values are now taken as boolean
(like "true" and "false") and not only {,0x}{0,1}.
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
It was not tested. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
The tests were using the setAsDouble version instead of the more generic setAs<Double>. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
use-convertto-for-boolean-parameter
branch
from
95daa50
to
bd767ad
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean parameters can now be set with values such as "true" and "false".
