Refactor signextend #154
Merged
Refactor signextend #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Refactored Sign extension out of the PartialProductGenerator to operate on it instead. You can choose which one you want
or build a new one. This makes the system more modular and names more clear.
Related Issue(s)
None
Testing
Ran existing regressions with sweep of sign extensions.
Backwards-compatibility
Yes. This changes the API of the PartialProductGenerator, Multiplier, and Mac.
Documentation
Yes. Code documentation (options) were updated as well as the markdown documenting multiplier components.