Fix jekyll build checks to match actual deployment, constrain version#79
Merged
mkorbel1 merged 4 commits intointel:mainfrom Jan 6, 2025
Merged
Fix jekyll build checks to match actual deployment, constrain version#79mkorbel1 merged 4 commits intointel:mainfrom
jekyll build checks to match actual deployment, constrain version#79mkorbel1 merged 4 commits intointel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The action "Jekyll-Deploy-Test-Action" was not doing exactly the same thing as the actual deployment, and a recent new version of ruby (3.4) was apparently not sufficiently backwards compatible.
https://github.com/intel/rohd-website/actions/runs/12638241511/job/35214099116
This PR ditches the action and instead uses the actual build step used in deployment to make sure it builds, and just skips the deploy step if it's only a PR.
It looks like we may soon need to update the minimum ruby version as well, but that's not included in this PR:
Related Issue(s)
N/A
Testing
This PR should test it
Backwards-compatibility
No
Documentation
No