-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New precheck procedure to enhance stability. #1453
Open
BalaBalaYi
wants to merge
21
commits into
intelligent-machine-learning:master
Choose a base branch
from
BalaBalaYi:new_precheck_procedure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New precheck procedure to enhance stability. #1453
BalaBalaYi
wants to merge
21
commits into
intelligent-machine-learning:master
from
BalaBalaYi:new_precheck_procedure
+543
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dlrover/python/master/args.py # dlrover/python/tests/test_args.py # docs/deployment/argument.md # go/elasticjob/pkg/controllers/master/master.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 81.60% 81.69% +0.08%
==========================================
Files 240 242 +2
Lines 24060 24270 +210
==========================================
+ Hits 19635 19827 +192
- Misses 4425 4443 +18 ☔ View full report in Codecov by Sentry. |
# Conflicts: # dlrover/python/common/global_context.py # dlrover/python/master/diagnosis/diagnosis_manager.py # dlrover/python/tests/test_args.py # dlrover/python/tests/test_diagnosis_manager.py # docs/deployment/argument.md
# Conflicts: # dlrover/python/common/constants.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
For details, please see the design document in the current PR.
Does this PR introduce any user-facing change?
User can enable or disable the pre-check function through job args. For details, please see the development document in the current PR.
How was this patch tested?
UT and simple training job.