adjust step hang default to 5 min #1542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majieyue
requested review from
workingloong,
samplise and
BalaBalaYi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1542 +/- ##
==========================================
- Coverage 83.23% 83.22% -0.01%
==========================================
Files 269 269
Lines 28143 28158 +15
==========================================
+ Hits 23424 23434 +10
- Misses 4719 4724 +5 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
approved these changes
May 13, 2025
majieyue
merged commit b885d9f
into
intelligent-machine-learning:master
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adjust default hang_timeout to 5min. And restrict hand_threshold between [MIN_HANG_DOWNTIME, HANG_DONWTIME]
Why are the changes needed?
5min is more appropriate than 10min
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT