Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The agent in the main process async saves the state dict to storage. #857

Merged

Conversation

workingloong
Copy link
Collaborator

No description provided.

@workingloong workingloong requested a review from liyzcj November 30, 2023 03:27
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (07a8adf) 76.53% compared to head (f907284) 76.59%.

Files Patch % Lines
dlrover/trainer/torch/elastic/checkpoint.py 86.51% 29 Missing ⚠️
dlrover/python/tests/test_ckpt_saver.py 78.72% 10 Missing ⚠️
dlrover/python/common/multi_process.py 90.24% 8 Missing ⚠️
dlrover/python/elastic_agent/torch/ckpt_saver.py 98.01% 2 Missing ⚠️
dlrover/python/elastic_agent/torch/training.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   76.53%   76.59%   +0.05%     
==========================================
  Files         163      165       +2     
  Lines       14288    14413     +125     
==========================================
+ Hits        10936    11039     +103     
- Misses       3352     3374      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@liyzcj liyzcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@workingloong workingloong merged commit bb28957 into intelligent-machine-learning:master Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants