Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the shm to storage at SGINT signal. #864

Conversation

workingloong
Copy link
Collaborator

What changes were proposed in this pull request?

Save the checkpointing state dict in shm to storage at SGINT signal.

Why are the changes needed?

Fix #863

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@workingloong workingloong requested a review from liyzcj December 1, 2023 02:13
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (84f6c86) 76.79% compared to head (9c908e7) 76.80%.

Files Patch % Lines
dlrover/python/elastic_agent/torch/training.py 71.42% 2 Missing ⚠️
dlrover/python/elastic_agent/torch/ckpt_saver.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
+ Coverage   76.79%   76.80%   +0.01%     
==========================================
  Files         165      165              
  Lines       14505    14523      +18     
==========================================
+ Hits        11139    11155      +16     
- Misses       3366     3368       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@liyzcj liyzcj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@workingloong workingloong merged commit a0f9d41 into intelligent-machine-learning:master Dec 1, 2023
@workingloong workingloong deleted the save-with-sigint branch December 1, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save the state dict from the memory to storage if the Pod is preempted.
2 participants