Fix PHP 8.3 deprecation: make explicitly nullable in ZabbixApiException #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 — while testing with PHP 8.3, I noticed a deprecation warning around the ZabbixApiException constructor.
Throwable $previous = null
is now considered implicitly nullable in PHP 8.3+, which triggers a warning.
This PR updates the constructor to:
public function __construct(string $message, int $code = 0, ?\Throwable $previous = null)
Why
Removes the PHP 8.3 deprecation warning
Keeps the package future-proof for PHP 8.4
No behavioral change, fully backwards compatible
Notes
This is a small change, but it should make life a bit easier for anyone running newer PHP versions. Thanks for maintaining this project — looking forward to chatting more at Zabbix Summit!