Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #42 envfile.properties unique per container #43

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix #42 envfile.properties unique per container #43

merged 1 commit into from
Dec 17, 2024

Conversation

antoinetran
Copy link
Contributor

Summary

Simply fix #42

Tested: result

ll ~/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/{init*,main*,wait*}
-rw-r--r-- 1 username groupppp 14646 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/init_envfile.properties
-rw-r--r-- 1 username groupppp  1722 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/init.out
-rw-r--r-- 1 username groupppp     2 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/init.status
-rw-r--r-- 1 username groupppp   375 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/main_envfile.properties
-rw-r--r-- 1 username groupppp   277 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/main.out
-rw-r--r-- 1 username groupppp     4 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/main.status
-rw-r--r-- 1 username groupppp   449 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/wait_envfile.properties
-rw-r--r-- 1 username groupppp  1632 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/wait.out
-rw-r--r-- 1 username groupppp     2 Dec 16 18:43 /home/username/.interlink/argo-workflows-147e7b1f-c71b-4b6a-ad86-46310d3d0be1/wait.status

Related issue :

dciangot
dciangot approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dciangot dciangot merged commit 8e07d0b into interTwin-eu:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dciangot dciangot dciangot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression envfile collision with multiple containers
2 participants
@antoinetran @dciangot