Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tj-actions/changed-files from 35 to 41 in /.github/workflows #122

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 2, 2024

Bumps tj-actions/changed-files from 35 to 41.

Release notes

Sourced from tj-actions/changed-files's releases.

v41

Changes in v41.0.1

What's Changed

Full Changelog: tj-actions/changed-files@v41...v41.0.1


Changes in v41.0.0

🔥 🔥 BREAKING CHANGE 🔥 🔥

A new safe_output input is now available to prevent outputting unsafe filename characters (Enabled by default). This would escape characters in the filename that could be used for command injection.

[!NOTE] This can be disabled by setting the safe_output to false this comes with a recommendation to store all outputs generated in an environment variable first before using them.

Example

...
    - name: Get changed files
      id: changed-files
      uses: tj-actions/changed-files@v40
      with:
        safe_output: false # set to false because we are using an environment variable to store the output and avoid command injection.
- name: List all added files
  env:
    ADDED_FILES: ${{ steps.changed-files.outputs.added_files }}
  run: |
    for file in "$ADDED_FILES"; do
      echo "$file was added"
    done

...

What's Changed

... (truncated)

Changelog

Sourced from tj-actions/changed-files's changelog.

Changelog

41.0.1 - (2023-12-24)

🐛 Bug Fixes

  • Update characters escaped by safe output (#1815) (716b1e1) - (Tonye Jack)

⚙️ Miscellaneous Tasks

  • deps: Update dependency eslint-plugin-prettier to v5.1.2 (7aaf10d) - (renovate[bot])

⬆️ Upgrades

  • Upgraded to v41 (#1811)

Co-authored-by: jackton1 jackton1@users.noreply.github.com (cc08e17) - (tj-actions[bot])

41.0.0 - (2023-12-23)

🐛 Bug Fixes

  • Update safe output regex and the docs (#1805) (ff2f6e6) - (tj-actions[bot])

⏪ Reverts

  • Revert "chore(deps): update actions/download-artifact action to v4" (#1806)

(4f573fe) - (Tonye Jack)

🔄 Update

  • Update README.md (6e79d6e) - (Tonye Jack)
  • Update README.md (d13ac19) - (Tonye Jack)
  • Update README.md (bb89f97) - (Tonye Jack)
  • Updated README.md (#1810)

Co-authored-by: renovate[bot] (1864078) - (tj-actions[bot])

  • Update README.md (#1808)

(47371c5) - (Tonye Jack)

📝 Other

  • feat: add safe_output input enabled by default

  • fix: migrate README to safe uses of interpolation

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v35...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jan 2, 2024
@github-management-service

It looks like you are reviewing a Dependabot upgrade PR! 🛠️
That’s great! Keeping our packages up to date to fix security issues in our stack is super important. Team Application Security wants to help make this process as easy and low friction as possible while still moving at pace.

We aim to merge Dependabot PRs within the below timeframes. The objectives are based on the severity of the security vulnerability we are mitigating with the upgrade:

Severity Target Merge (days)
CRITICAL 7 days
HIGH 14 days
MEDIUM 30 days
LOW 90 days

🎯 Target merge date for this PR: 16/01/2024 🎯

FAQ

What if we aren’t vulnerable to this particular CVE? Do we still have to upgrade the package? It’s still a good idea to upgrade the package if we can. With new code patterns and paths being introduced every day, we have no guarantee that we won’t later make ourselves vulnerable. Keeping packages up to date as a matter of due course is also good hygiene.
What if we’re not vulnerable and upgrading is going to be a lot of work? In these cases it’s a good idea to list out the steps you took to confirm we are not vulnerable in this PR. The PR can then be closed and the corresponding Dependabot Alert should be dismissed with the triage steps included as a comment. Please get in touch with Team Application Security via #ask-security before dismissing any CRITICAL alerts.
This is a major version upgrade that requires substantial code refactoring. What should I do? If the upgrade requires substantial refactoring then it is possible that we will miss the objectives we have outlined above. In these cases, you should add the dependabot-refactor-required label to this PR and ping #ask-security for further advice.

@github-management-service

Hello @intercom/team-app-sec 👋 this PR fixes a security vulnerability (GHSA-mcph-m25j-8j63) in a repository you own - intercom/Intercom-OpenAPI. We have obligation to update our dependencies in a timely manner in order to keep our applications secure. Please take a look at the PR and merge it as soon as possible.

@github-management-service

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

daniel-colgan
daniel-colgan previously approved these changes Jan 4, 2024
@daniel-colgan daniel-colgan dismissed their stale review January 4, 2024 16:32

Need to review breaking change

@Eclairemoy Eclairemoy merged commit 1798fed into main Sep 25, 2024
1 check passed
@Eclairemoy Eclairemoy deleted the dependabot/github_actions/dot-github/workflows/tj-actions/changed-files-41 branch September 25, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert-severity-HIGH dependabot-reminded dependabot-semver-major dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants