Fix Integration: Recognize clicks from components that use href-to (ember-paper) #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use href-to with a component from https://github.com/miguelcobain/ember-paper that renders an anchor element.
{{#paper-button href=(href-to "settings") class="href-to"}}Settings{{/paper-button}}
I am able to use the href-to helper to set the
href
attribute on the component, which renders as expected. Great!But with this, href-to didn't recognize when I clicked the link. I got the hard native browser redirect rather than a nice Ember router transition. It was because every component's element gets the
.ember-view
class which didn't fit the conditions in href-to's initializer.So I made this pull request to update the initializer. Now href-to recognizes and smoothly transitions clicks on anchor elements when they have the
.href-to
class even if they are components.To stay out of the way, href-to continues to not intervene when there is an action set on an element.