Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Preserve queryParams #47

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Jun 21, 2016

  1. Reproduce issues

    cibernox committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    5d44a7b View commit details
    Browse the repository at this point in the history
  2. It works

    cibernox committed Jun 21, 2016
    Configuration menu
    Copy the full SHA
    fbed8ef View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2016

  1. Use routing service

    cibernox committed Jun 23, 2016
    Configuration menu
    Copy the full SHA
    1b70f17 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2016

  1. Configuration menu
    Copy the full SHA
    1c3231c View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2016

  1. Created complete failing test for queryParams

    The basic idea is that when a link doesn’t specify the value for a query
    param, the current value is preserved. 
    
    So, given the hierarchy
    
    ```
    qps // defines a QP named “string”
      qps.details // defines a QP named “nestedString”
        qps.details.more // defines a QP named “doubleNestedString”
    ```
    
    Links inside `qps.details.more` that point to `qps.details` will contain
    “nestedString=bar&string=foo”, but never “doubleNestedString”.
    Links inside `qps.details` that point to `qps` will contain “string=foo”,
    but never “nestedString” or “doubleNestedString”.
    Links inside `qps.details` that point to `qps.details` with a different
    will model will contain “string=foo” but never “nestedString” or “doubleNestedString”.
    Links from a route to any descendant route will always include all the 
    query params defined in the path.
    cibernox committed Jul 2, 2016
    Configuration menu
    Copy the full SHA
    c179ed3 View commit details
    Browse the repository at this point in the history