Merge branch 'bc/upgrade-ts' into bc/1464/remix-v2-updates-2

interledger · Jan 18, 2024 · 6afae62 · 6afae62
2 parents ca9ad2c + 4043c3c
commit 6afae62
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 47 deletions.
diff --git a/localenv/mock-account-servicing-entity/tsconfig.json b/localenv/mock-account-servicing-entity/tsconfig.json
@@ -11,7 +11,6 @@
     "target": "ES2019",
     "strict": true,
     "allowJs": true,
-    "forceConsistentCasingInFileNames": true,
     "baseUrl": ".",
     "paths": {
       "~/*": ["./app/*"]

diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
     "prettier": "^3.2.2",
     "ts-jest": "^29.1.1",
     "tunnelmole": "^2.2.13",
-    "typescript": "^4.9.5",
+    "typescript": "^5.3.3",
     "uuid": "^9.0.1"
   },
   "dependenciesMeta": {

diff --git a/packages/auth/src/graphql/scalars/UInt8.ts b/packages/auth/src/graphql/scalars/UInt8.ts
@@ -10,7 +10,7 @@ function coerceUInt8Value(value: number | string | unknown): number {
     throw new TypeError('Provided value is not number or string.')
   }
   const nValue = Number(value)
-  if (Number.isInteger(nValue) && value >= 0 && value <= 255) {
+  if (Number.isInteger(nValue) && nValue >= 0 && nValue <= 255) {
     return nValue
   }
   throw new GraphQLError('Provided value is not a UInt8.', {

diff --git a/packages/auth/src/tests/context.ts b/packages/auth/src/tests/context.ts
@@ -26,9 +26,7 @@ export function createContext<T extends AppContext>(
         maxAge: 60 * 1000,
         signed: true
       },
-      // Only accepts Middleware<DefaultState, DefaultContext> for some reason, koa is Middleware<DefaultState, AppContext>
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      koa as any
+      koa
     )
   )
   const ctx = koa.createContext(req, res)

diff --git a/packages/backend/src/graphql/scalars/UInt8.ts b/packages/backend/src/graphql/scalars/UInt8.ts
@@ -10,7 +10,7 @@ function coerceUInt8Value(value: number | string | unknown): number {
     throw new TypeError('Provided value is not number or string.')
   }
   const nValue = Number(value)
-  if (Number.isInteger(nValue) && value >= 0 && value <= 255) {
+  if (Number.isInteger(nValue) && nValue >= 0 && nValue <= 255) {
     return nValue
   }
   throw new GraphQLError('Provided value is not a UInt8.', {

diff --git a/packages/frontend/tsconfig.json b/packages/frontend/tsconfig.json
@@ -10,7 +10,6 @@
     "target": "ES2019",
     "strict": true,
     "allowJs": true,
-    "forceConsistentCasingInFileNames": true,
     "baseUrl": ".",
     "paths": {
       "~/*": ["./app/*"]

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -66,7 +66,7 @@
 
     /* Advanced Options */
     "skipLibCheck": true /* Skip type checking of declaration files. */,
-    "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
+    // "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */,
     "resolveJsonModule": true
   }
 }