fix(backend): exactOptionalPropertyTypes errors

packages/backend/src/open_payments/payment/incoming/model.ts

@@ -211,19 +211,27 @@ export class IncomingPayment
   public toOpenPaymentsType(
     walletAddress: WalletAddress
   ): OpenPaymentsIncomingPayment {
-    return {
+    let openPaymentsIncomingPayment: OpenPaymentsIncomingPayment = {
       id: this.getUrl(walletAddress),
       walletAddress: walletAddress.url,
-      incomingAmount: this.incomingAmount
-        ? serializeAmount(this.incomingAmount)
-        : undefined,
       receivedAmount: serializeAmount(this.receivedAmount),
       completed: this.completed,
-      metadata: this.metadata ?? undefined,
       createdAt: this.createdAt.toISOString(),
       updatedAt: this.updatedAt.toISOString(),
       expiresAt: this.expiresAt.toISOString()
     }
+
+    if (this.incomingAmount) {
+      openPaymentsIncomingPayment.incomingAmount = serializeAmount(
+        this.incomingAmount
+      )
+    }
+
+    if (this.metadata) {
+      openPaymentsIncomingPayment.metadata = this.metadata
+    }
+
+    return openPaymentsIncomingPayment
   }
 
   public toOpenPaymentsTypeWithMethods(

packages/backend/src/payment-method/ilp/peer/service.test.ts

@@ -231,13 +231,23 @@ describe('Peer Service', (): void => {
       async ({ liquidityThreshold }): Promise<void> => {
         const peer = await createPeer(deps)
         const { http, maxPacketAmount, staticIlpAddress, name } = randomPeer()
-        const updateOptions: UpdateOptions = {
+
+        let updateOptions: UpdateOptions = {
           id: peer.id,
           http,
-          maxPacketAmount,
-          staticIlpAddress,
-          name,
-          liquidityThreshold
+          staticIlpAddress
+        }
+
+        if (maxPacketAmount !== undefined) {
+          updateOptions.maxPacketAmount = maxPacketAmount
+        }
+
+        if (name !== undefined) {
+          updateOptions.name = name
+        }
+
+        if (liquidityThreshold !== undefined) {
+          updateOptions.liquidityThreshold = liquidityThreshold
         }
 
         const peerOrError = await peerService.update(updateOptions)

packages/backend/src/payment-method/ilp/stream-credentials/service.test.ts

@@ -11,6 +11,7 @@ import { createWalletAddress } from '../../../tests/walletAddress'
 import { truncateTables } from '../../../tests/tableManager'
 import assert from 'assert'
 import { IncomingPaymentState } from '../../../graphql/generated/graphql'
+import Objection from 'objection'
 
 describe('Stream Credentials Service', (): void => {
   let deps: IocContract<AppServices>
@@ -57,12 +58,16 @@ describe('Stream Credentials Service', (): void => {
       ${IncomingPaymentState.Expired}
     `(
       `returns undefined for $state incoming payment`,
-      async ({ state }): Promise<void> => {
-        await incomingPayment.$query(knex).patch({
-          state,
-          expiresAt:
-            state === IncomingPaymentState.Expired ? new Date() : undefined
-        })
+      async ({ state }: { state: IncomingPaymentState }): Promise<void> => {
+        let paymentPatch: Partial<IncomingPayment> = {
+          state
+        }
+
+        if (state === IncomingPaymentState.Expired) {
+          paymentPatch.expiresAt = new Date()
+        }
+
+        await incomingPayment.$query(knex).patch(paymentPatch)
         expect(streamCredentialsService.get(incomingPayment)).toBeUndefined()
       }
     )