Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use latest version of TB and TB node client #1181

Merged
merged 12 commits into from
Mar 14, 2023
Merged

chore: use latest version of TB and TB node client #1181

merged 12 commits into from
Mar 14, 2023

Conversation

sabineschaller
Copy link
Member

@sabineschaller sabineschaller commented Mar 1, 2023 •
edited
Loading

Changes proposed in this pull request

  • upgrade tigerbeetle node client to 0.12.18
  • use tigerbeetle image corresponding to 0.12.18

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: backend Changes in the backend package. type: localenv Local playground type: source Changes business logic labels Mar 1, 2023
@sabineschaller sabineschaller marked this pull request as ready for review March 1, 2023 16:18
@wilsonianb
Copy link
Contributor

😕

https://github.com/tigerbeetledb/tigerbeetle/blob/main/src/clients/node/package.json#L3

@sabineschaller
Copy link
Member Author

😕

* [fix(deps): update dependency tigerbeetle-node to ^0.12.4 #1168](https://github.com/interledger/rafiki/pull/1168)

https://github.com/tigerbeetledb/tigerbeetle/blob/main/src/clients/node/package.json#L3

That's a bummer. What do we do now?

@github-actions github-actions bot removed the type: localenv Local playground label Mar 8, 2023
@wilsonianb wilsonianb mentioned this pull request Mar 12, 2023
Closed
8 tasks
@sabineschaller
Copy link
Member Author

@wilsonianb docker image as well as node client were updated 3 days ago. That's the hash of the docker image I used.

@wilsonianb
Copy link
Contributor

I'm checking with team TB to figure out what commits and docker images correspond to what npm versions

wilsonianb
wilsonianb approved these changes Mar 14, 2023
View reviewed changes
packages/backend/src/tests/tigerbeetle.ts
`${TIGERBEETLE_DIR}/${tigerbeetleFile}`
])
.withWaitStrategy(
Wait.forLogMessage(
`info(main): 0: formatted: cluster=${tigerbeetleClusterId}`
`info(main): 0: formatted: cluster=${tigerbeetleClusterId} replica_count=1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is replica_count new?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Took me forever to figure that out. The docs on in the TB Readme also weren't updated properly. I pinged the team about that.

@sabineschaller sabineschaller merged commit 8c0967b into main Mar 14, 2023
@sabineschaller sabineschaller deleted the s2-tigerbeetle-latest branch March 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonianb wilsonianb wilsonianb approved these changes

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabineschaller @wilsonianb