Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): backend tenant graphql resolvers #3234

Open
wants to merge 10 commits into
base: 2893/multi-tenancy-v1
Choose a base branch
from
Open

feat(backend): backend tenant graphql resolvers #3234

wants to merge 10 commits into from

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Jan 21, 2025 •
edited by mkurapov
Loading

Changes proposed in this pull request

  • Adds the following resolvers to the backend Admin GraphQL API:
    • whoami
    • tenant
    • tenants
    • createTenant
    • updateTenant
    • deleteTenant

Context

Fixes #3124.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: mock-ase pkg: mock-account-service-lib labels Jan 21, 2025
@njlie njlie force-pushed the nl/3124/backend-tenant-resolvers branch from 23e34b2 to 99d6982 Compare January 21, 2025 22:16
@njlie njlie marked this pull request as ready for review January 21, 2025 22:20
koekiebox

This comment was marked as outdated.

Sign in to view

koekiebox
koekiebox requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in the PR looks good.
Just the Bruno collection to be added.

@mkurapov mkurapov linked an issue Jan 23, 2025 that may be closed by this pull request
[Multi-Tenant] backend Admin Tenant API #3124
Open
6 tasks
@njlie njlie requested a review from koekiebox January 24, 2025 21:26
koekiebox
koekiebox approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

koekiebox
koekiebox requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/interledger/rafiki/actions/runs/12996726301/job/36246174979?pr=3234

Just need to look at the unit and integration tests failing.

mkurapov
mkurapov reviewed Jan 28, 2025
View reviewed changes
packages/backend/scripts/init.sh Outdated Show resolved Hide resolved
packages/backend/src/graphql/schema.graphql Outdated Show resolved Hide resolved
packages/backend/src/graphql/resolvers/tenant.test.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pkg: auth Changes in the GNAP auth package. label Jan 28, 2025
@njlie njlie requested review from koekiebox and mkurapov January 28, 2025 20:51
koekiebox
koekiebox approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@koekiebox koekiebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mkurapov
mkurapov reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final things

packages/backend/jest.env.js Outdated Show resolved Hide resolved
packages/backend/scripts/init.sh Outdated Show resolved Hide resolved
packages/backend/src/graphql/resolvers/tenant.test.ts Outdated Show resolved Hide resolved
@njlie njlie requested a review from mkurapov January 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlairCurrey BlairCurrey BlairCurrey approved these changes

@koekiebox koekiebox koekiebox approved these changes

@golobitch golobitch Awaiting requested review from golobitch

@mkurapov mkurapov Awaiting requested review from mkurapov

Assignees

@njlie njlie

Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-Tenant] backend Admin Tenant API
4 participants
@njlie @koekiebox @BlairCurrey @mkurapov