-
Notifications
You must be signed in to change notification settings - Fork 98
docs: mi/3419/rafiki testnet deploy #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs
|
Backend test is failing, which may be related to the issue Max posted about in the #rafiki-team channel in Slack. The preview link does display the updates: Deployment Example (new menu item ) |
This reverts commit 1f3278f.
] | ||
}, | ||
{ | ||
label: 'Deployment example', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My gut says that the deployment example should be a child section under Deploy Rafiki, but let's talk about that later, when you're ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it should be a child section under Deploy Rafiki. I made it a different section in anticipation of the end-to-end guide for the wallet app. However, I wonder if the team will feel that this guide is unnecessary once the wallet guide is available, because the Test network architecture shouldn't be suggested as a production deployment.
packages/documentation/src/content/docs/integration/deploy-to-prod/01-architecture-overview.mdx
Show resolved
Hide resolved
- **Auth server** (`auth.your-wallet.com`): Handles <LinkOut href='openpayments.dev'>Open Payments</LinkOut> authentication and authorization | ||
- **Backend** (`backend.your-wallet.com`): Core Interledger protocol implementation | ||
- **Admin API** (`admin.your-wallet.com`): Administrative functions and account management via GraphQL API | ||
- **Database**: Stores Interledger accounts, payment pointers, and transaction data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wallet addresses be part of this, too? I'm not sure if this is for payment pointers only, since it's Interledger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll update this to wallet addresses instead.
packages/documentation/src/content/docs/integration/deploy-to-prod/06-troubleshooting.mdx
Show resolved
Hide resolved
| `project_id` | - | Yes | GCP Project ID where resources will be created | | ||
| `region` | `us-central1` | No | Primary GCP region for cluster and resources | | ||
| `cluster_name` | `rafiki-wallet-cluster` | No | Name of the GKE cluster | | ||
| `domain_name` | - | Yes | Primary domain for your wallet (e.g., `mywallet.com`) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this higher in the table, so the two required variables are one after the other?
|
||
<div class="overflow-table"> | ||
|
||
| Record Type | Name | Value | TTL | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought - Since all the record types are A records, you might be able to change the section title from DNS record configuration to DNS A record configuration (I can see how that may look a bit odd) and get rid of the Record Type column completely.
- `YOUR_PROJECT_ID` - Replace with your GCP project ID | ||
- `YOUR_REGISTRY` - Replace with your container registry | ||
- `YOUR_EMAIL` - Replace with your administrative email | ||
- `<generated-secret>` - Generate using `openssl rand -base64 32` (see Secrets Management guide) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to Secrets Management guide
|
||
Your deployed services are available at these URLs: | ||
|
||
| Service | URL | Purpose | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the items in the URL column be wrapped in back ticks? I'm not saying they should be.
Addresses issue docs: Add a deployment guide using Test Network #3419
Related issues linked using
fixes #number
Tests added/updated
Make sure that all checks pass
Bruno collection updated (if necessary)
Documentation issue created with
user-docs
label (if necessary)OpenAPI specs updated (if necessary)