Skip to content

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Sep 24, 2025

Changes proposed in this pull request

  • Adds text during the consent screen to properly reference a subject information request.

Context

Closes RAF-997.

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

Copy link

github-actions bot commented Sep 24, 2025

🚀 Performance Test Results

Test Configuration:

  • VUs: 4
  • Duration: 1m0s

Test Metrics:

  • Requests/s: 39.22
  • Iterations/s: 13.08
  • Failed Requests: 0.00% (0 of 2363)
📜 Logs

> performance@1.0.0 run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 853 kB 14 kB/s
     data_sent......................: 1.8 MB 30 kB/s
     http_req_blocked...............: avg=7.41µs   min=2.38µs  med=5.47µs   max=917.54µs p(90)=6.66µs   p(95)=7.18µs  
     http_req_connecting............: avg=568ns    min=0s      med=0s       max=696.2µs  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=101.31ms min=8.3ms   med=81.52ms  max=908.59ms p(90)=172.76ms p(95)=192.37ms
       { expected_response:true }...: avg=101.31ms min=8.3ms   med=81.52ms  max=908.59ms p(90)=172.76ms p(95)=192.37ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2363
     http_req_receiving.............: avg=92.8µs   min=32.73µs med=77.63µs  max=3.15ms   p(90)=115.96µs p(95)=155.48µs
     http_req_sending...............: avg=37.93µs  min=10.08µs med=28.24µs  max=2.37ms   p(90)=42.06µs  p(95)=58.79µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=101.18ms min=8.19ms  med=81.44ms  max=908.5ms  p(90)=172.63ms p(95)=192.21ms
     http_reqs......................: 2363   39.221319/s
     iteration_duration.............: avg=305.42ms min=185.6ms med=289.51ms max=1.08s    p(90)=347.75ms p(95)=380.1ms 
     iterations.....................: 788    13.079306/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

@njlie njlie requested review from cozminu and mkurapov September 29, 2025 21:15
@cozminu cozminu marked this pull request as ready for review October 2, 2025 09:41
Copy link
Contributor

@cozminu cozminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
]
},
"subject": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a separate example folder that just has two requests, this one (with just the subject request), and the grant continuation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result, we should have the mock ASE be able to handle requests with just the subject field (without showing the 0 amount):

Screenshot 2025-10-06 at 14 00 38

@njlie njlie requested a review from mkurapov October 9, 2025 19:42
@njlie njlie merged commit 55aa0a1 into cozmin/raf-996 Oct 14, 2025
32 of 38 checks passed
@njlie njlie deleted the nl/raf-997 branch October 14, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants