Skip to content

[_]: chore/add logs around 404s #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jzunigax2 merged 1 commit into from
Jan 30, 2026
Merged

[_]: chore/add logs around 404s #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/core/buckets/usecase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export class BucketsUsecase {
});

if (!bucketEntry) {
console.warn(`[getFileInfo] Bucket entry not found in DB - bucketId: ${bucketId}, fileId: ${fileId}`);
throw new BucketEntryNotFoundError(fileId);
}

Expand All @@ -238,6 +239,7 @@ export class BucketsUsecase {
if (axios.isAxiosError(error)) {
const axiosError = error as AxiosError;
if (axiosError.response?.status === 404) {
console.warn(`[getFileInfo] Download links returned 404 - bucketEntryId: ${bucketEntry.id}, fileId: ${fileId}, url: ${axiosError.config?.url}`);
throw new BucketEntryNotFoundError(fileId);
}
}
Expand Down
3 changes: 3 additions & 0 deletions lib/server/routes/buckets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,9 @@ BucketsRouter.prototype.getFileInfo = async function (req, res, next) {
return res.status(200).send(fileInfo);
} catch (err) {
if (err instanceof BucketEntryNotFoundError || err instanceof BucketEntryFrameNotFoundError || err instanceof BucketNotFoundError) {
log.warn('getFileInfo: Not found - bucket: %s, file: %s, user: %s, client: %s, error: %s',
req.params.id, req.params.file, req.user?.uuid, driveClient, err.message);

return next(new errors.NotFoundError(err.message));
}

Expand Down
Loading