Fix: print human readable errors on terminal

src/commands/add-cert.ts

@@ -41,7 +41,6 @@ export default class AddCert extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/config.ts

@@ -45,7 +45,6 @@ export default class Config extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/create-folder.ts

@@ -70,7 +70,6 @@ export default class CreateFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/delete-permanently-file.ts

@@ -47,7 +47,6 @@ export default class DeletePermanentlyFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/delete-permanently-folder.ts

@@ -47,7 +47,6 @@ export default class DeletePermanentlyFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/download-file.ts

@@ -118,7 +118,6 @@ export default class DownloadFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/list.ts

@@ -82,7 +82,6 @@ export default class List extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/login.ts

@@ -92,7 +92,6 @@ export default class Login extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/logout.ts

@@ -32,7 +32,6 @@ export default class Logout extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/logs.ts

@@ -22,7 +22,6 @@ export default class Logs extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/move-file.ts

@@ -52,7 +52,6 @@ export default class MoveFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/move-folder.ts

@@ -54,7 +54,6 @@ export default class MoveFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/rename-file.ts

@@ -52,7 +52,6 @@ export default class RenameFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/rename-folder.ts

@@ -47,7 +47,6 @@ export default class RenameFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-clear.ts

@@ -54,7 +54,6 @@ export default class TrashClear extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-file.ts

@@ -42,7 +42,6 @@ export default class TrashFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-folder.ts

@@ -42,7 +42,6 @@ export default class TrashFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-list.ts

@@ -67,7 +67,6 @@ export default class TrashList extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-restore-file.ts

@@ -54,7 +54,6 @@ export default class TrashRestoreFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/trash-restore-folder.ts

@@ -56,7 +56,6 @@ export default class TrashRestoreFolder extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/upload-file.ts

@@ -157,7 +157,7 @@ export default class UploadFile extends Command {
         }
       }
     } catch (error) {
-      ErrorUtils.report(this.error.bind(this), error, { command: this.id });
+      ErrorUtils.report(error, { command: this.id });
     }
 
     progressBar?.update(100);
@@ -184,7 +184,6 @@ export default class UploadFile extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/webdav-config.ts

@@ -93,7 +93,6 @@ export default class WebDAVConfig extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/webdav.ts

@@ -68,7 +68,6 @@ export default class Webdav extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/commands/whoami.ts

@@ -47,7 +47,6 @@ export default class Whoami extends Command {
       error,
       command: this.id,
       logReporter: this.log.bind(this),
-      errorReporter: this.error.bind(this),
       jsonFlag: flags['json'],
     });
     this.exit(1);

src/hooks/prerun/auth_check.ts

@@ -27,7 +27,6 @@ const hook: Hook<'prerun'> = async function (opts) {
         error: err,
         command: Command.id,
         logReporter: this.log.bind(this),
-        errorReporter: this.error.bind(this),
         jsonFlag,
       });
       opts.context.exit(1);

src/utils/cli.utils.ts

@@ -175,14 +175,12 @@ export class CLIUtils {
   static readonly catchError = ({
     error,
     logReporter,
-    errorReporter,
     command,
     jsonFlag,
   }: {
     error: Error;
     command?: string;
     logReporter: (message: string) => void;
-    errorReporter: (message: string) => void;
     jsonFlag?: boolean;
   }) => {
     let message;
@@ -196,7 +194,7 @@ export class CLIUtils {
     if (jsonFlag) {
       CLIUtils.consoleLog(JSON.stringify({ success: false, message }));
     } else {
-      ErrorUtils.report(errorReporter, error, { command });
+      ErrorUtils.report(error, { command });
       CLIUtils.error(logReporter, message);
     }
   };

src/utils/errors.utils.ts

@@ -1,11 +1,18 @@
+import { logger } from './logger.utils';
+import { types } from 'node:util';
+
+export function isError(error: unknown): error is Error {
+  return types.isNativeError(error);
+}
+
 export class ErrorUtils {
-  static report(reporter: (error: string) => void, error: unknown, props: Record<string, unknown> = {}) {
-    if (error instanceof Error) {
-      reporter(
+  static report(error: unknown, props: Record<string, unknown> = {}) {
+    if (isError(error)) {
+      logger.error(
         `[REPORTED_ERROR]: ${error.message}\nProperties => ${JSON.stringify(props, null, 2)}\nStack => ${error.stack}`,
       );
     } else {
-      reporter(`[REPORTED_ERROR]: ${JSON.stringify(error)}\nProperties => ${JSON.stringify(props, null, 2)}\n`);
+      logger.error(`[REPORTED_ERROR]: ${JSON.stringify(error)}\nProperties => ${JSON.stringify(props, null, 2)}\n`);
     }
   }
 }

src/utils/logger.utils.ts

@@ -49,19 +49,3 @@ export const webdavLogger = winston.createLogger({
     }),
   ],
 });
-
-if (process.env.NODE_ENV !== 'production') {
-  webdavLogger.add(
-    new winston.transports.Console({
-      format: winston.format.simple(),
-    }),
-  );
-}
-
-if (process.env.NODE_ENV !== 'production') {
-  logger.add(
-    new winston.transports.Console({
-      format: winston.format.simple(),
-    }),
-  );
-}

src/webdav/middewares/auth.middleware.ts

@@ -3,6 +3,7 @@ import { SdkManager } from '../../services/sdk-manager.service';
 import { AuthService } from '../../services/auth.service';
 import { webdavLogger } from '../../utils/logger.utils';
 import { XMLUtils } from '../../utils/xml.utils';
+import { isError } from '../../utils/errors.utils';
 
 export const AuthMiddleware = (authService: AuthService): RequestHandler => {
   return (_, res, next) => {
@@ -13,12 +14,14 @@ export const AuthMiddleware = (authService: AuthService): RequestHandler => {
         next();
       } catch (error) {
         let message = 'Authentication required to access this resource.';
-        if ('message' in (error as Error) && (error as Error).message.trim().length > 0) {
-          message = (error as Error).message;
+        if (isError(error)) {
+          message = error.message;
+          if (error.stack) {
+            webdavLogger.error(`Error from AuthMiddleware: ${message}\nStack: ${error.stack}`);
+          } else {
+            webdavLogger.error(`Error from AuthMiddleware: ${message}`);
+          }
         }
-
-        webdavLogger.error('Error from AuthMiddleware: ' + message);
-
         const errorBodyXML = XMLUtils.toWebDavXML(
           {
             [XMLUtils.addDefaultNamespace('responsedescription')]: message,

src/webdav/middewares/errors.middleware.ts

@@ -1,14 +1,21 @@
 import { ErrorRequestHandler } from 'express';
 import { webdavLogger } from '../../utils/logger.utils';
 import { XMLUtils } from '../../utils/xml.utils';
+import { isError } from '../../utils/errors.utils';
 
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 export const ErrorHandlingMiddleware: ErrorRequestHandler = (err, req, res, _) => {
-  webdavLogger.error(`[ERROR MIDDLEWARE] [${req.method.toUpperCase()} - ${req.url}]`, err);
+  const message = isError(err) ? err.message : 'Something went wrong';
+
+  if (isError(err) && err.stack) {
+    webdavLogger.error(`[ERROR MIDDLEWARE] [${req.method.toUpperCase()} - ${req.url}] ${message}\nStack: ${err.stack}`);
+  } else {
+    webdavLogger.error(`[ERROR MIDDLEWARE] [${req.method.toUpperCase()} - ${req.url}] ${message}`);
+  }
 
   const errorBodyXML = XMLUtils.toWebDavXML(
     {
-      [XMLUtils.addDefaultNamespace('responsedescription')]: 'message' in err ? err.message : 'Something went wrong',
+      [XMLUtils.addDefaultNamespace('responsedescription')]: message,
     },
     {},
     'error',

test/commands/login.test.ts

@@ -6,6 +6,12 @@ import Login from '../../src/commands/login';
 import { AuthService } from '../../src/services/auth.service';
 import { CLIUtils, NoFlagProvidedError } from '../../src/utils/cli.utils';
 
+vi.mock('../../src/utils/logger.utils', () => ({
+  logger: {
+    error: vi.fn(),
+  },
+}));
+
 describe('Login Command', () => {
   beforeEach(() => {
     vi.restoreAllMocks();
@@ -26,7 +32,8 @@ describe('Login Command', () => {
       await Login.run(['--non-interactive', `--password="${UserLoginFixture.password}"`]);
       fail('Expected function to throw an error, but it did not.');
     } catch (error) {
-      expect((error as Error).message).to.contain(new NoFlagProvidedError('email').message);
+      expect((error as Error).message).to.contain('EEXIT: 1');
+      expect((error as Error & { oclif?: { exit: number } }).oclif?.exit).to.equal(1);
     }
 
     expect(getValueFromFlagsSpy).toHaveBeenCalledOnce();
@@ -50,7 +57,8 @@ describe('Login Command', () => {
       await Login.run(['--non-interactive', `--email="${UserLoginFixture.email}"`]);
       fail('Expected function to throw an error, but it did not.');
     } catch (error) {
-      expect((error as Error).message).to.contain(new NoFlagProvidedError('password').message);
+      expect((error as Error).message).to.contain('EEXIT: 1');
+      expect((error as Error & { oclif?: { exit: number } }).oclif?.exit).to.equal(1);
     }
 
     expect(getValueFromFlagsSpy).toHaveBeenCalledTimes(2);
@@ -78,7 +86,8 @@ describe('Login Command', () => {
       ]);
       fail('Expected function to throw an error, but it did not.');
     } catch (error) {
-      expect((error as Error).message).to.contain(new NoFlagProvidedError('twofactor').message);
+      expect((error as Error).message).to.contain('EEXIT: 1');
+      expect((error as Error & { oclif?: { exit: number } }).oclif?.exit).to.equal(1);
     }
 
     expect(getValueFromFlagsSpy).toHaveBeenCalledTimes(3);