Merged
Conversation
AlexisMora
force-pushed
the
feat/pb-5111-upload-folder-facade
branch
from
d0a3d33 to
60c154e
Compare
larryrider
reviewed
Nov 27, 2025
Contributor
|
whenever you can check sonarcloud issues and add a pr description 🚀 |
|
larryrider
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been Added
I have created a Upload facade so that we can safely handle all of the steps on the upload process such as scanning, error handling, uploading folders, uploading files..etc and also have it decoupled from the actual command file. This way we can just have all of the logic inside the services and this face and have the upload-folder command as a sort of "endpoint"