Skip to content

[PB-5714] Use base64 structs#20

Merged
TamaraFinogina merged 3 commits intomasterfrom
use_base64_structs
Jan 15, 2026
Merged

[PB-5714] Use base64 structs#20
TamaraFinogina merged 3 commits intomasterfrom
use_base64_structs

Conversation

@TamaraFinogina
Copy link
Contributor

@TamaraFinogina TamaraFinogina commented Jan 15, 2026

Description

Use structures with Base64 fields instead of converting everything to base64

Related Issues

Relates to PB-5714

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Unit tests

@TamaraFinogina TamaraFinogina self-assigned this Jan 15, 2026
@TamaraFinogina TamaraFinogina marked this pull request as ready for review January 15, 2026 13:45
.DS_Store Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont add this file, add .DS_Store to the .gitignore

Copy link
Contributor Author

@TamaraFinogina TamaraFinogina Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in gitignore already (https://github.com/internxt/crypto/blob/master/.gitignore#L112). I'll just delete it

@sonarqubecloud
Copy link

@TamaraFinogina TamaraFinogina merged commit 8d71afb into master Jan 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants