Skip to content

feat: Enhance accessibility by adding ARIA roles and attributes to interactive elements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
egalvis27 merged 7 commits into from
Oct 24, 2025
Merged

feat: Enhance accessibility by adding ARIA roles and attributes to interactive elements #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1bb3b2e
feat: Enhance accessibility by adding ARIA roles and attributes to in…
egalvis27 Oct 17, 2025
8eadac5
refactor: Remove redundant role attributes from interactive elements
egalvis27 Oct 17, 2025
973958c
fix: Ensure startCleanup returns a promise and update cleanup confirm…
egalvis27 Oct 17, 2025
238a795
refactor: Simplify section data retrieval by removing unnecessary nul…
egalvis27 Oct 20, 2025
e7bf42c
Merge branch 'master' into fix/fix-code-sonar-issues
egalvis27 Oct 21, 2025
81dd767
Merge branch 'master' into fix/fix-code-sonar-issues
egalvis27 Oct 24, 2025
4a29ab5
Merge branch 'master' into fix/fix-code-sonar-issues
egalvis27 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/frontend/features/cleaner/cleaner-section.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function CleanerSection({

function confirmCleanup() {
if (report) {
startCleanup(useCleanerViewModelHook.viewModel);
void startCleanup(useCleanerViewModelHook.viewModel);
}
setShowConfirmDialog(false);
}
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/features/cleaner/cleaner.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export type CleanerContextType = {
diskSpace: number;
sectionKeys: CleanerSectionKey[];
generateReport: (force?: boolean) => Promise<void>;
startCleanup: (viewModel: CleanerViewModel) => void;
startCleanup: (viewModel: CleanerViewModel) => Promise<void>;
stopCleanup: () => void;
setInitialCleaningState: () => void;
};
2 changes: 1 addition & 1 deletion src/frontend/features/cleaner/components/cleanup-confirm-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function CleanupConfirmDialog({ isVisible, onConfirm, onCancel, useTransl
return (
<div className="fixed inset-0 z-50 flex items-center justify-center">
{/* Backdrop */}
<div className="bg-opacity-50 absolute inset-0 bg-black backdrop-blur-sm" onClick={onCancel} />
<div className="bg-opacity-50 absolute inset-0 bg-black backdrop-blur-sm" onClick={onCancel} aria-hidden="true" />

{/* Dialog */}
<div className="bg-surface relative mx-4 w-full max-w-md rounded-lg p-6 shadow-xl dark:bg-gray-800">
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/features/cleaner/components/cleanup-size-indicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export function CleanupSizeIndicator({ selectedSize, totalSize, segmentDetails,

acc.elements.push(
<path
key={index}
key={`segment-${index}`}
d="M 20 100 A 80 80 0 0 1 180 100"
fill="none"
stroke={segment.color}
Expand Down
2 changes: 1 addition & 1 deletion src/frontend/features/cleaner/components/section-detail-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function SectionDetailHeader({
return (
<div className="dark:bg-gray-5 flex items-center justify-between p-4">
<div className="flex items-center gap-3">
<div className="flex items-center gap-1 text-blue-600 hover:cursor-pointer dark:text-blue-400" onClick={onClose}>
<div className="flex items-center gap-1 text-blue-600 hover:cursor-pointer dark:text-blue-400" onClick={onClose} aria-hidden="true">
<CaretDoubleRight color="#0066ff" weight="bold" />
</div>
<h3 className="text-lg font-semibold text-gray-900 dark:text-gray-100">{sectionConfig[sectionName].name}</h3>
Expand Down
21 changes: 9 additions & 12 deletions src/frontend/features/cleaner/components/section-detail-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,18 @@ export function SectionDetailMenu({
onToggleItem,
useTranslationContext,
}: Readonly<Props>) {
if (!sectionName) return null;
Copy link
Collaborator

@dajimenezriv-internxt dajimenezriv-internxt Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the props, sectionName is always defined.

const parentRef = useRef<HTMLDivElement>(null);

const sectionData = report[sectionName];
const sectionViewModel = viewModel[sectionName];
if (!sectionViewModel) return null;
const items = sectionData?.items || [];

const virtualizer = useVirtualizer({
count: items.length,
getScrollElement: () => parentRef.current,
estimateSize: () => 80,
overscan: 10,
});

const stats = getSectionStats({ viewModel: sectionViewModel, allItems: sectionData.items });

Expand All @@ -50,16 +57,6 @@ export function SectionDetailMenu({
}
}

const parentRef = useRef<HTMLDivElement>(null);
const items = sectionData.items;

const virtualizer = useVirtualizer({
count: items.length,
getScrollElement: () => parentRef.current,
estimateSize: () => 80,
overscan: 10,
});

return (
<div
className={
Expand Down
1 change: 1 addition & 0 deletions src/frontend/features/cleaner/components/section-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export function SectionItem({

<div
className="flex flex-1 items-end justify-end"
aria-hidden="true"
onClick={(e) => {
e.stopPropagation();
onToggleSectionExpansion(sectionName);
Expand Down
Loading