refactor: streamline device identifier handling and error management #230
Conversation
| attributes: { endpoint: '/backup/v2/devices' }, | ||
| }); | ||
| return left(error); | ||
| return { error: error }; |
There was a problem hiding this comment.
[Non blocking] You don't really need to write error twice. You can use this eslint rule to show a warning: https://eslint.org/docs/latest/rules/object-shorthand
| export type FetchDeviceProps = { deviceIdentifier: DeviceIdentifierDTO } | { uuid: string } | { legacyId: string }; | ||
|
|
||
| async function getDeviceByProps(props: FetchDeviceProps): Promise<Either<Error, Device | null>> { | ||
| async function getDeviceByProps(props: FetchDeviceProps) { |
There was a problem hiding this comment.
[Non blocking] Just to give some information. We found that maybe this is no longer necessary since this is just a backup to recover to the device identifier of the user in case the app is uninstalled. However, the backup paths are lost anyway, so this doesn't provide a solution.
|
|
||
| const legacyId = configStore.get('deviceId'); | ||
| const savedUUID = configStore.get('deviceUUID'); | ||
| logger.debug({ |
There was a problem hiding this comment.
Aren't these logs useful to track if the device is migrated or in linux are we logging already the requests so we can see the that?
|
|
||
| const device = createNewDeviceEither.getRight(); | ||
| const user = DependencyInjectionUserProvider.get(); | ||
| user.backupsBucket = device.bucket; |
There was a problem hiding this comment.
Technically backupsBucket is always defined so we shouldn't do this anymore. We had the same code on windows and we deleted it. Check if that's true and you can simplify this.
There was a problem hiding this comment.
I ran some tests and confirmed that the backupsBucket does not exist for new users until they create their first device, so this line is still necessary.
There was a problem hiding this comment.
Oh shit, then we have a bug on windows. Thanks for the info :)
|
2 participants
What is Changed / Added
Why