feat: implement download progress tracking in StorageFileDownloader and related components #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd related components
…ivirus availability
AlexisMora
reviewed
Feb 6, 2026
src/context/storage/StorageFiles/application/offline/MakeStorageFileAvaliableOffline.ts
Outdated
Show resolved
Hide resolved
src/context/storage/StorageFiles/application/sync/StorageRemoteChangesSyncher.ts
Outdated
Show resolved
Hide resolved
…cking function and update related components
…rageRemoteChangesSyncher
egalvis27
commented
Feb 9, 2026
AlexisMora
reviewed
Feb 9, 2026
| @@ -0,0 +1,28 @@ | |||
| import { Readable, Writable, pipeline } from 'stream'; | |||
AlexisMora
approved these changes
Feb 9, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Download progress reporting has been updated for both 'make available offline' and on-demand download operations.
Why
There are issues with download progress reporting: the completion event is triggered prematurely, before the actual process finishes. This misleads users into thinking the file is ready for use when it is not.
The solution now accounts for the disk write process when reporting download progress. This prevents users from attempting to interact with files that are still being written to disk and eliminates false reports that downloads are not working.