Skip to content

fix: remove unnecessary ThreadSafeReference #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patricioxavier8 merged 1 commit into from
Jan 27, 2026
Merged

fix: remove unnecessary ThreadSafeReference #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions XPCBackupService/Entities/BackupTreeNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,31 +98,25 @@ class BackupTreeNode {
}

private func nodeIsSynced(url: URL, deviceId: Int) throws -> SyncedNode? {
guard let syncedNode = backupRealm.findSyncedNode(url: url, deviceId: deviceId) else {
return nil
}

let threadSafeRef = ThreadSafeReference(to: syncedNode)
guard let syncedNode = backupRealm.findSyncedNode(url: url, deviceId: deviceId) else {
return nil
}

guard let resolvedNode = backupRealm.resolveSyncedNode(reference: threadSafeRef) else {
return nil
}
guard let fileModificationDate = try self.getFileModificationDate() else {
return nil
}

guard let fileModificationDate = try self.getFileModificationDate() else {
return nil
}
let syncedNodeDate = syncedNode.updatedAt

let syncedNodeDate = resolvedNode.updatedAt
if syncedNodeDate < fileModificationDate && self.type != .folder {
self.syncStatus = .NEEDS_UPDATE
self.remoteId = syncedNode.remoteId
self.remoteUuid = syncedNode.remoteUuid
return nil
}

if syncedNodeDate < fileModificationDate && self.type != .folder {
self.syncStatus = .NEEDS_UPDATE
self.remoteId = resolvedNode.remoteId
self.remoteUuid = resolvedNode.remoteUuid
return nil
}

return resolvedNode
}
return syncedNode
}

func syncBelowNodes(withOperationQueue: OperationQueue, dependingOfOperation: BackupTreeNodeSyncOperation? = nil, onError: @escaping (Error) -> Void) throws -> Void {
let operation = BackupTreeNodeSyncOperation(backupTreeNode: self)
Expand Down